Page MenuHomeFreeBSD
Differential D46271

Fix EFI loader reproducibility with lld
ClosedPublic
Actions

Authored by dim on Aug 11 2024, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 2:20 AM
Unknown Object (File)
Fri, Nov 1, 7:26 PM
Unknown Object (File)
Fri, Nov 1, 6:57 PM
Unknown Object (File)
Mon, Oct 21, 1:02 PM
Unknown Object (File)
Thu, Oct 17, 9:23 PM
Unknown Object (File)
Sun, Oct 6, 9:09 AM
Unknown Object (File)
Oct 3 2024, 3:19 PM
Unknown Object (File)
Oct 1 2024, 1:55 PM
View All 21 Files
Subscribers
bcran
dab
imp

Details

Reviewers
brooks
cperciva
emaste
manu
Commits
rGe664cd1dc5fb: Fix EFI loader reproducibility with lld
rG8a4fd438ef6c: Fix EFI loader reproducibility with lld
rG85434cac6ef2: Fix EFI loader reproducibility with lld
rGf5ce3f4ef562: Fix EFI loader reproducibility with lld
Summary

When the various loaders under stand/efi are built, the resulting
binaries differ over multiple runs, even if WITH_REPRODUCIBLE_BUILD is
used. This is caused by lld multithreading and the custom linker scripts
for the loaders, and affects the following binaries:

  • loader_4th.efi
  • loader_4th.sym
  • loader_4th.sym.full
  • loader_lua.efi
  • loader_lua.sym
  • loader_lua.sym.full
  • loader_simp.efi
  • loader_simp.sym
  • loader_simp.sym.full

Work around this by disabling lld threading for these binaries.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58991
Build 55878: arc lint + arc unit

Event Timeline

dim created this revision.Aug 11 2024, 7:54 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 11 2024, 7:54 PM
Herald added subscribers: dab, bcran, imp. · View Herald Transcript
dim requested review of this revision.Aug 11 2024, 7:54 PM
Harbormaster completed remote builds in B58987: Diff 141996.Aug 11 2024, 7:54 PM
emaste accepted this revision.Aug 11 2024, 8:49 PM

OK as a workaround but we ought to report this upstream

This revision is now accepted and ready to land.Aug 11 2024, 8:49 PM
imp added a comment.EditedAug 11 2024, 9:54 PM

Looks good, assuming we don't already hsve a LDFLAGS.lld that we add to LDFLAGS like we do for CFLAGS.

cperciva added a comment.Aug 12 2024, 12:40 AM
In D46271#1055178, @imp wrote:

Looks good, assuming we don't already hsve a LDFLAGS.lld that we add to LDFLAGS like we do for CFLAGS.

We do have LDFLAGS.lld, and using that works (without needing the .if/.endif).

dim updated this revision to Diff 142010.Aug 12 2024, 11:54 AM

Use LDFLAGS.lld.

This revision now requires review to proceed.Aug 12 2024, 11:54 AM
Harbormaster completed remote builds in B58990: Diff 142010.Aug 12 2024, 11:54 AM
dim updated this revision to Diff 142011.Aug 12 2024, 11:54 AM

Undo arc stupidity.

Harbormaster completed remote builds in B58991: Diff 142011.Aug 12 2024, 11:54 AM
emaste accepted this revision.Aug 12 2024, 11:59 AM
This revision is now accepted and ready to land.Aug 12 2024, 11:59 AM
Closed by commit rGf5ce3f4ef562: Fix EFI loader reproducibility with lld (authored by dim). · Explain WhyAug 12 2024, 1:32 PM
This revision was automatically updated to reflect the committed changes.
dim added a commit: rGf5ce3f4ef562: Fix EFI loader reproducibility with lld.
dim added a commit: rG85434cac6ef2: Fix EFI loader reproducibility with lld.Aug 15 2024, 6:34 AM
dim added a commit: rG8a4fd438ef6c: Fix EFI loader reproducibility with lld.Aug 15 2024, 6:39 AM
dim added a commit: rGe664cd1dc5fb: Fix EFI loader reproducibility with lld.Aug 15 2024, 7:43 AM

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
5 lines

Diff 142011

View Options

stand/efi/loader/Makefile

Loading...