Differential D46271

Fix EFI loader reproducibility with lld
ClosedPublic
Actions

Authored by dim on Aug 11 2024, 7:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 20, 9:48 PM

	Unknown Object (File)
	Thu, Apr 16, 1:20 PM

	Unknown Object (File)
	Thu, Apr 16, 10:12 AM

	Unknown Object (File)
	Thu, Apr 16, 9:10 AM

	Unknown Object (File)
	Thu, Apr 16, 5:16 AM

	Unknown Object (File)
	Thu, Apr 16, 2:32 AM

	Unknown Object (File)
	Tue, Apr 14, 6:19 PM

	Unknown Object (File)
	Thu, Apr 9, 6:34 PM

Subscribers

Details

Reviewers

brooks
cperciva
emaste
manu

Commits

rGe664cd1dc5fb: Fix EFI loader reproducibility with lld
rG8a4fd438ef6c: Fix EFI loader reproducibility with lld
rG85434cac6ef2: Fix EFI loader reproducibility with lld
rGf5ce3f4ef562: Fix EFI loader reproducibility with lld

Summary

When the various loaders under stand/efi are built, the resulting
binaries differ over multiple runs, even if WITH_REPRODUCIBLE_BUILD is
used. This is caused by lld multithreading and the custom linker scripts
for the loaders, and affects the following binaries:

loader_4th.efi
loader_4th.sym
loader_4th.sym.full
loader_lua.efi
loader_lua.sym
loader_lua.sym.full
loader_simp.efi
loader_simp.sym
loader_simp.sym.full

Work around this by disabling lld threading for these binaries.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 58990
Build 55877: arc lint + arc unit

Event Timeline

dim created this revision.Aug 11 2024, 7:54 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 11 2024, 7:54 PM

Herald added subscribers: dab, bcran, imp. · View Herald Transcript

dim requested review of this revision.Aug 11 2024, 7:54 PM

Harbormaster completed remote builds in B58987: Diff 141996.Aug 11 2024, 7:54 PM

OK as a workaround but we ought to report this upstream

This revision is now accepted and ready to land.Aug 11 2024, 8:49 PM

Looks good, assuming we don't already hsve a LDFLAGS.lld that we add to LDFLAGS like we do for CFLAGS.

In D46271#1055178, @imp wrote:

Looks good, assuming we don't already hsve a LDFLAGS.lld that we add to LDFLAGS like we do for CFLAGS.

We do have LDFLAGS.lld, and using that works (without needing the .if/.endif).

Use LDFLAGS.lld.

This revision now requires review to proceed.Aug 12 2024, 11:54 AM

Harbormaster completed remote builds in B58990: Diff 142010.Aug 12 2024, 11:54 AM

Undo arc stupidity.

Harbormaster completed remote builds in B58991: Diff 142011.Aug 12 2024, 11:54 AM

emaste accepted this revision.Aug 12 2024, 11:59 AM

This revision is now accepted and ready to land.Aug 12 2024, 11:59 AM

Closed by commit rGf5ce3f4ef562: Fix EFI loader reproducibility with lld (authored by dim). · Explain WhyAug 12 2024, 1:32 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rGf5ce3f4ef562: Fix EFI loader reproducibility with lld.

dim added a commit: rG85434cac6ef2: Fix EFI loader reproducibility with lld.Aug 15 2024, 6:34 AM

dim added a commit: rG8a4fd438ef6c: Fix EFI loader reproducibility with lld.Aug 15 2024, 6:39 AM

dim added a commit: rGe664cd1dc5fb: Fix EFI loader reproducibility with lld.Aug 15 2024, 7:43 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

6 lines

9 lines

stand/

efi/

loader/

5 lines

sys/

dev/

usb/

net/

1 line

2 lines

quirk/

1 line

Diff 142010

share/man/man4/cdce.4

Loading...

share/man/man4/ure.4

Loading...

stand/efi/loader/Makefile

Loading...

sys/dev/usb/net/if_cdce.c

Loading...

sys/dev/usb/net/if_ure.c

Loading...

sys/dev/usb/quirk/usb_quirk.c

Loading...