build: use bare (and portable) echo instead of echo -n
ClosedPublic
Actions

Authored by imp on Dec 1 2023, 7:38 PM.

Details

Reviewers

jrtc27
emaste

Commits

rG7b085f14b73c: build: use bare (and portable) echo instead of echo -n

Summary

There's no need to use echo -n here. A single echo will do nicely.
This fixes the post-buildworld output on a macos build, where echo -n
is implemented like System V instead of BSD (so you get two lines
first one starting with -n).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Dec 1 2023, 7:38 PM

Herald added a subscriber: emaste. · View Herald TranscriptDec 1 2023, 7:38 PM

imp requested review of this revision.Dec 1 2023, 7:38 PM

Harbormaster completed remote builds in B54737: Diff 130910.Dec 1 2023, 7:38 PM

s/echo -n/printf '%s'/ is the other option, but this seems like the sensible approach here.

This revision is now accepted and ready to land.Dec 1 2023, 7:45 PM

emaste added inline comments.Dec 1 2023, 8:13 PM

Makefile.inc1
1810	or just extend the line beyond 80 cols?

imp added inline comments.Dec 1 2023, 9:23 PM

Makefile.inc1
1810	interesting notion, but this file is mostly < 80 already and this extends it too far past... At least at the moment... Maybe in the future.

this extends it too far past

IMO for log messages etc. we should generally prefer not wrapping them and ignore line lengths, so that if someone can find them when doing e.g. grep "seconds, ncpu"