netlink: convert to IfAPI.
ClosedPublic
Actions

Authored by melifaro on Jun 16 2023, 2:02 PM.

Details

Reviewers

jhibbits

Group Reviewers

network

Commits

rG793793553558: netlink: convert to IfAPI.

Summary

Convert to IfAPI everything except IF_AFDATA_WLOCK usage in neigh.c.

I don't think it's a good idea to to expose locking as function-based API. I'd prefer to leave neigh.c with access to a private header for some time.
I two options here: 1) move actual LLE insertion code inside if_lltable.c

refactoring IF_AFDATA locking in general to have per-af lock instead of a global one.

Currently I'm leaning for the first option, which is fairly simple.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52103
Build 48994: arc lint + arc unit

Event Timeline

melifaro created this revision.Jun 16 2023, 2:02 PM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptJun 16 2023, 2:02 PM

melifaro requested review of this revision.Jun 16 2023, 2:02 PM

Harbormaster completed remote builds in B52103: Diff 123337.Jun 16 2023, 2:02 PM

melifaro edited the summary of this revision. (Show Details)Jun 16 2023, 2:06 PM

melifaro added reviewers: jhibbits, network.

I agree with option 1, moving the LLE insertion code to if_llatbl.c

sys/netlink/route/neigh.c
43	I'm fine with including the private header for now, let's make sure "for now" doesn't become "forever", though :)

This revision is now accepted and ready to land.Jun 16 2023, 3:36 PM

In D40577#923867, @jhibbits wrote:

I agree with option 1, moving the LLE insertion code to if_llatbl.c

Yep. I drafted something, but I need to think about the desired KPI a bit more, as I want to accommodate child LLE inclusion (IPv4 over IPv6 LLEs ATM). Probably I'll come up with something in the next couple of days.