Page MenuHomeFreeBSD
Differential D55880

ifnet: Move SIOCSIFVNET from ifhwioctl() to ifioctl()
Needs ReviewPublic
Actions

Authored by zlei on Mon, Mar 16, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 8, 9:55 AM
Unknown Object (File)
Sun, Apr 5, 1:29 PM
Unknown Object (File)
Sun, Apr 5, 1:20 PM
Unknown Object (File)
Tue, Mar 31, 12:19 AM
Unknown Object (File)
Sat, Mar 28, 8:36 PM
Unknown Object (File)
Fri, Mar 27, 7:05 PM
Unknown Object (File)
Wed, Mar 25, 5:24 AM
Unknown Object (File)
Wed, Mar 25, 4:09 AM
View All 16 Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
jamie
kp
glebius
Group Reviewers
network
Summary

SIOCSIFVNET is not a hardware ioctl. Move it to where it belongs.

Where here, rewrite the logic of checking whether we are moving the
interface from and to the same vnet or not, since it is obviously not
safe to access the members of an interface until it is proven that the
interface is on the "active" list.

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Mon, Mar 16, 6:31 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptMon, Mar 16, 6:31 PM
zlei requested review of this revision.Mon, Mar 16, 6:31 PM
zlei mentioned this in D55832: ifnet: if_vmove_(loan|reclaim): Refactor a bit the checking of src / dst vnet.Mon, Mar 16, 6:37 PM
zlei added inline comments.Mon, Mar 16, 6:43 PM
sys/net/if.c
1205

The error ENXIO means the interface does not exists. Should choose a better error to distinguish that with the case not found child prison / vnet.

glebius requested changes to this revision.Mon, Mar 16, 6:53 PM

Correct me if I am wrong, but this seems to be two separate changes. Can this be split please?

This revision now requires changes to proceed.Mon, Mar 16, 6:53 PM
zlei added a comment.Tue, Mar 17, 2:43 AM
In D55880#1278503, @glebius wrote:

Correct me if I am wrong, but this seems to be two separate changes. Can this be split please?

Ah I mixed the changes to the comments into this revision. I'll update.

zlei updated this revision to Diff 173795.Tue, Mar 17, 8:48 AM

Removed the changes to comments.

zlei added inline comments.Tue, Mar 17, 8:52 AM
sys/net/if.c
1199–1200

This revision is based on latest main, so this removal is competing with D55875 .

I'd personally prefer to land this first. With this change it is more robust to check "the moving between the same vnet".

zlei updated this revision to Diff 175017.Tue, Apr 7, 4:44 AM
zlei edited the summary of this revision. (Show Details)

Rebased on latest main.

zlei added a comment.Tue, Apr 7, 4:48 AM

Landed D55875 after running extensive tests.

@glebius Does it look good to you now ?

Revision Contents
Changeset List

PathSize
sys/
net/
44 lines

Diff 175017

View Options

sys/net/if.c

Loading...