Page MenuHomeFreeBSD

pmc: Initialise and check the pm_flags field for CONFIGURELOG
ClosedPublic

Authored by jrtc27 on May 10 2023, 5:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 8:10 PM
Unknown Object (File)
Wed, Aug 12, 3:44 PM
Unknown Object (File)
Mon, Aug 10, 8:08 AM
Unknown Object (File)
Sun, Aug 9, 5:11 PM
Unknown Object (File)
Sat, Aug 8, 4:33 PM
Unknown Object (File)
Sat, Aug 8, 2:48 AM
Unknown Object (File)
Fri, Aug 7, 5:09 PM
Unknown Object (File)
Mon, Aug 3, 8:04 AM
Subscribers

Details

Summary

Whilst the former is not breaking, the latter is, and so this will be
followed by a bump to the pmc major version. This will allow the flags
to actually be usable in future, as otherwise we cannot distinguish
uninitialised stack junk from a deliberately-initialised value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51788
Build 48679: arc lint + arc unit

Event Timeline

It is annoying, but this represents a new distinct error return from the syscall, and should be added to the ERRORS list in hwpmc(4).

This revision is now accepted and ready to land.May 11 2023, 6:19 PM
This revision now requires review to proceed.May 30 2023, 10:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 30 2023, 11:38 PM
This revision was automatically updated to reflect the committed changes.