Page MenuHomeFreeBSD

pmc: Initialise and check the pm_flags field for CONFIGURELOG
ClosedPublic

Authored by jrtc27 on May 10 2023, 5:40 PM.
Tags
None
Referenced Files
F131773437: D40049.id121817.diff
Sat, Oct 11, 1:32 AM
Unknown Object (File)
Wed, Oct 8, 2:48 PM
Unknown Object (File)
Sun, Sep 28, 5:10 AM
Unknown Object (File)
Wed, Sep 17, 7:20 PM
Unknown Object (File)
Wed, Sep 17, 4:20 AM
Unknown Object (File)
Sep 11 2025, 1:11 AM
Unknown Object (File)
Sep 8 2025, 5:35 AM
Unknown Object (File)
Sep 5 2025, 4:59 AM
Subscribers

Details

Summary

Whilst the former is not breaking, the latter is, and so this will be
followed by a bump to the pmc major version. This will allow the flags
to actually be usable in future, as otherwise we cannot distinguish
uninitialised stack junk from a deliberately-initialised value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It is annoying, but this represents a new distinct error return from the syscall, and should be added to the ERRORS list in hwpmc(4).

This revision is now accepted and ready to land.May 11 2023, 6:19 PM
This revision now requires review to proceed.May 30 2023, 10:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 30 2023, 11:38 PM
This revision was automatically updated to reflect the committed changes.