Page MenuHomeFreeBSD

pmc: Initialise and check the pm_flags field for CONFIGURELOG
ClosedPublic

Authored by jrtc27 on May 10 2023, 5:40 PM.
Tags
None
Referenced Files
F138444985: D40049.diff
Tue, Dec 2, 6:12 AM
Unknown Object (File)
Sat, Nov 29, 6:39 AM
Unknown Object (File)
Tue, Nov 18, 4:28 PM
Unknown Object (File)
Sun, Nov 16, 6:00 AM
Unknown Object (File)
Thu, Nov 6, 1:44 AM
Unknown Object (File)
Mon, Nov 3, 10:09 AM
Unknown Object (File)
Oct 27 2025, 1:41 AM
Unknown Object (File)
Oct 21 2025, 3:39 AM
Subscribers

Details

Summary

Whilst the former is not breaking, the latter is, and so this will be
followed by a bump to the pmc major version. This will allow the flags
to actually be usable in future, as otherwise we cannot distinguish
uninitialised stack junk from a deliberately-initialised value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It is annoying, but this represents a new distinct error return from the syscall, and should be added to the ERRORS list in hwpmc(4).

This revision is now accepted and ready to land.May 11 2023, 6:19 PM
This revision now requires review to proceed.May 30 2023, 10:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 30 2023, 11:38 PM
This revision was automatically updated to reflect the committed changes.