Paths

Table of Contentst

Differential D40049

pmc: Initialise and check the pm_flags field for CONFIGURELOG
ClosedPublic
Actions

Authored by jrtc27 on May 10 2023, 5:40 PM.

Tags

None

Referenced Files

	F171570494: D40049.diff
	Fri, Sep 11, 8:00 PM

	Unknown Object (File)
	Fri, Sep 11, 5:13 AM

	Unknown Object (File)
	Thu, Sep 10, 9:06 AM

	Unknown Object (File)
	Thu, Sep 10, 9:00 AM

	Unknown Object (File)
	Sun, Sep 6, 1:51 PM

	Unknown Object (File)
	Sun, Sep 6, 1:58 AM

	Unknown Object (File)
	Sat, Sep 5, 7:45 PM

	Unknown Object (File)
	Sat, Sep 5, 7:16 AM

Subscribers

Details

Reviewers

jhb
jkoshy
mhorne
gnn

Commits

rG8e63e787abbd: pmc: Initialise and check the pm_flags field for CONFIGURELOG

Summary

Whilst the former is not breaking, the latter is, and so this will be
followed by a bump to the pmc major version. This will allow the flags
to actually be usable in future, as otherwise we cannot distinguish
uninitialised stack junk from a deliberately-initialised value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.May 10 2023, 5:40 PM

Herald added a reviewer: gnn. · View Herald TranscriptMay 10 2023, 5:40 PM

Herald added a subscriber: imp. · View Herald Transcript

jrtc27 requested review of this revision.May 10 2023, 5:40 PM

Harbormaster completed remote builds in B51426: Diff 121817.May 10 2023, 5:40 PM

jrtc27 added a child revision: D40050: pmc: Bump major version for just-committed breaking changes.May 10 2023, 5:41 PM

It is annoying, but this represents a new distinct error return from the syscall, and should be added to the ERRORS list in hwpmc(4).

This revision is now accepted and ready to land.May 11 2023, 6:19 PM

jhb accepted this revision.May 22 2023, 7:06 PM

Add error case to hwpmc(4)

This revision now requires review to proceed.May 30 2023, 10:43 PM

Harbormaster completed remote builds in B51788: Diff 122632.May 30 2023, 10:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 30 2023, 11:38 PM

Closed by commit rG8e63e787abbd: pmc: Initialise and check the pm_flags field for CONFIGURELOG (authored by jrtc27). · Explain Why

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG8e63e787abbd: pmc: Initialise and check the pm_flags field for CONFIGURELOG.

Revision Contents
Changeset List

Path

Size

lib/

libpmc/

1 line

share/

man/

man4/

6 lines

sys/

dev/

hwpmc/

6 lines

Diff 122633

lib/libpmc/libpmc.c

Loading...

share/man/man4/hwpmc.4

Loading...

sys/dev/hwpmc/hwpmc_mod.c

Loading...