Page MenuHomeFreeBSD
Differential D39921

pmap: Convert boolean_t to bool.
ClosedPublic
Actions

Authored by jhb on May 1 2023, 10:21 PM.
Tags
None
Referenced Files
F160491985: D39921.id121361.diff
Thu, Jun 25, 2:00 AM
Unknown Object (File)
Tue, Jun 23, 9:07 PM
Unknown Object (File)
Tue, Jun 23, 12:45 AM
Unknown Object (File)
Sun, Jun 21, 8:32 PM
Unknown Object (File)
Sun, Jun 21, 6:44 PM
Unknown Object (File)
Sun, Jun 14, 10:35 AM
Unknown Object (File)
Fri, Jun 12, 5:48 AM
Unknown Object (File)
Sun, May 31, 8:08 AM
View All Files
Subscribers
andrew
imp
jhibbits
riscv

Details

Reviewers
emaste
manu
kib
markj
andrew
Commits
rG1f1b2286fd5a: pmap: Convert boolean_t to bool.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51294
Build 48185: arc lint + arc unit

Event Timeline

jhb created this revision.May 1 2023, 10:21 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 1 2023, 10:21 PM
Herald added subscribers: riscv, jhibbits, andrew, imp. · View Herald Transcript
jhb requested review of this revision.May 1 2023, 10:21 PM
jhb added a parent revision: D39920: pmap_{un}map_io_transient: Use bool instead of boolean_t..
jhb added a child revision: D39922: acpi_button: Replace boolean_t with better types..
Harbormaster completed remote builds in B51294: Diff 121361.May 1 2023, 10:22 PM
jhb added reviewers: kib, markj.May 1 2023, 10:23 PM

This change might be a bit much size-wise but I didn't see any simple ways to split up into smaller increments really aside from the pmap_map_io_transient change earlier in this stack.

imp added a comment.May 1 2023, 11:15 PM

seems OK, but the length of this made my eyes glaze over, so I'm not clicking accept.

kib accepted this revision.May 2 2023, 1:28 AM

boolean_t is the mach' type AFAIK. I am curious why making this change.

This revision is now accepted and ready to land.May 2 2023, 1:28 AM
jhb added a comment.May 4 2023, 7:31 PM
In D39921#908767, @kib wrote:

boolean_t is the mach' type AFAIK. I am curious why making this change.

Prompted by the discussion around clang 16, I'm doing a kind of cleanup pass migrating from boolean_t to C99 bool as a general rule.

This API change in particular is a bit more invasive, and I might wait a bit on this one (it also will need an exp-run probably).

jhb added a commit: rG1f1b2286fd5a: pmap: Convert boolean_t to bool..Jan 31 2024, 11:33 PM
Herald added a reviewer: andrew. · View Herald TranscriptJan 31 2024, 11:33 PM
Herald added a reviewer: andrew. · View Herald Transcript
jhb closed this revision.Jan 31 2024, 11:34 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
205 lines
include/
6 lines
arm/
arm/
156 lines
include/
2 lines
20 lines
arm64/
arm64/
71 lines
i386/
i386/
153 lines
14 lines
include/
4 lines
14 lines
powerpc/
aim/
50 lines
50 lines
135 lines
booke/
44 lines
10 lines
4 lines
include/
10 lines
4 lines
powerpc/
22 lines
riscv/
riscv/
63 lines
vm/
14 lines

Diff 121361

View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/amd64/include/pmap.h

Loading...
View Options

sys/arm/arm/pmap-v6.c

Loading...
View Options

sys/arm/include/pmap-v6.h

Loading...
View Options

sys/arm/include/pmap_var.h

Loading...
View Options

sys/arm64/arm64/pmap.c

Loading...
View Options

sys/i386/i386/pmap.c

Loading...
View Options

sys/i386/i386/pmap_base.c

Loading...
View Options

sys/i386/include/pmap.h

Loading...
View Options

sys/i386/include/pmap_base.h

Loading...
View Options

sys/powerpc/aim/mmu_oea.c

Loading...
View Options

sys/powerpc/aim/mmu_oea64.c

Loading...
View Options

sys/powerpc/aim/mmu_radix.c

Loading...
View Options

sys/powerpc/booke/pmap.c

Loading...
View Options

sys/powerpc/booke/pmap_32.c

Loading...
View Options

sys/powerpc/booke/pmap_64.c

Loading...
View Options

sys/powerpc/include/mmuvar.h

Loading...
View Options

sys/powerpc/include/pmap.h

Loading...
View Options

sys/powerpc/powerpc/pmap_dispatch.c

Loading...
View Options

sys/riscv/riscv/pmap.c

Loading...
View Options

sys/vm/pmap.h

Loading...