Page MenuHomeFreeBSD
Differential D38392

amd64 ia32 vdso: always define some __vdso_ symbols
ClosedPublic
Actions

Authored by kib on Feb 5 2023, 9:46 PM.
Tags
None
Referenced Files
F168554406: D38392.id116825.diff
Sat, Aug 29, 12:15 AM
F168493972: D38392.id116649.diff
Fri, Aug 28, 4:32 PM
F168421924: D38392.id116545.diff
Fri, Aug 28, 5:32 AM
F168416168: D38392.id116825.diff
Fri, Aug 28, 4:23 AM
Unknown Object (File)
Tue, Aug 25, 3:50 PM
Unknown Object (File)
Tue, Aug 25, 9:17 AM
Unknown Object (File)
Tue, Aug 25, 7:17 AM
Unknown Object (File)
Thu, Aug 20, 10:43 AM
View All Files
Subscribers
imp
val_packett.cool

Details

Reviewers
emaste
dim
jrtc27
val_packett.cool
Commits
rGee8448712065: amd64 ia32 vdso: always define some __vdso_ symbols
rG5bb807fed462: amd64: record a dependency of vdso on its linker script
Summary
It is reported that llvm16 ld.lld warns about undefined symbols
referenced by the VERSION script.

Also

amd64: record a dependency of vdso on its linker script

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Feb 5 2023, 9:46 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 5 2023, 9:46 PM
kib requested review of this revision.Feb 5 2023, 9:46 PM
kib mentioned this in D38389: Fix building the ia32 vDSO with --no-undefined-version.
kib updated this revision to Diff 116648.Feb 6 2023, 10:00 PM
kib retitled this revision from amd64 ia32 vdso: PROVIDE conditionally defined symbols to amd64 ia32 vdso: always define some __vdso_ symbols.
jrtc27 added a comment.Feb 6 2023, 10:01 PM

Defining empty stubs seems like a bad idea, at least make them ud2 or something if you're going to take that approach?

kib added a comment.Feb 6 2023, 10:04 PM
In D38392#873555, @jrtc27 wrote:

Defining empty stubs seems like a bad idea, at least make them ud2 or something if you're going to take that approach?

Not sure why, but ok.

kib updated this revision to Diff 116649.Feb 6 2023, 10:04 PM

Use undefined instruction in non-configured stubs.

val_packett.cool accepted this revision.Feb 7 2023, 1:34 AM
This revision is now accepted and ready to land.Feb 7 2023, 1:34 AM
emaste accepted this revision.Feb 8 2023, 11:49 PM

OK

Closed by commit rG5bb807fed462: amd64: record a dependency of vdso on its linker script (authored by kib). · Explain WhyFeb 9 2023, 2:37 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG5bb807fed462: amd64: record a dependency of vdso on its linker script.
kib added a commit: rGee8448712065: amd64 ia32 vdso: always define some __vdso_ symbols.

Revision Contents
Changeset List

PathSize
sys/
amd64/
ia32/
6 lines
conf/
4 lines

Diff 116648

View Options

sys/amd64/ia32/ia32_sigtramp.S

Loading...
View Options

sys/conf/files.amd64

Loading...