amd64 ia32 vdso: always define some __vdso_ symbols
ClosedPublic
Actions

Authored by kib on Feb 5 2023, 9:46 PM.

Details

Reviewers

emaste
dim
jrtc27
val_packett.cool

Commits

rGee8448712065: amd64 ia32 vdso: always define some __vdso_ symbols
rG5bb807fed462: amd64: record a dependency of vdso on its linker script

Summary

It is reported that llvm16 ld.lld warns about undefined symbols
referenced by the VERSION script.

Also

amd64: record a dependency of vdso on its linker script

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Feb 5 2023, 9:46 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 5 2023, 9:46 PM

kib requested review of this revision.Feb 5 2023, 9:46 PM

kib mentioned this in D38389: Fix building the ia32 vDSO with --no-undefined-version.

kib updated this revision to Diff 116648.Feb 6 2023, 10:00 PM

kib retitled this revision from amd64 ia32 vdso: PROVIDE conditionally defined symbols to amd64 ia32 vdso: always define some __vdso_ symbols.

Defining empty stubs seems like a bad idea, at least make them ud2 or something if you're going to take that approach?

In D38392#873555, @jrtc27 wrote:

Defining empty stubs seems like a bad idea, at least make them ud2 or something if you're going to take that approach?

Not sure why, but ok.

Use undefined instruction in non-configured stubs.

val_packett.cool accepted this revision.Feb 7 2023, 1:34 AM

This revision is now accepted and ready to land.Feb 7 2023, 1:34 AM

Closed by commit rG5bb807fed462: amd64: record a dependency of vdso on its linker script (authored by kib). · Explain WhyFeb 9 2023, 2:37 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG5bb807fed462: amd64: record a dependency of vdso on its linker script.

kib added a commit: rGee8448712065: amd64 ia32 vdso: always define some __vdso_ symbols.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

ia32/

ia32_sigtramp.S

6 lines

conf/

files.amd64

4 lines

Diff 116648

View Options

sys/amd64/ia32/ia32_sigtramp.S