stand: share bootinfo.c between EFI and KBOOT
ClosedPublic
Actions

Authored by imp on Feb 1 2023, 11:15 PM.

Details

Reviewers

tsoome
kevans
manu

Commits

rG0928550c3e17: stand: share bootinfo.c between EFI and KBOOT

Summary

Connect efi's bootinfo.c to the kboot build, and adjust to use
the kboot specific routines.

The getrootmount() call is independent of EFI. Remove ifdefs so it's
called for kboot too.

The differences between the kboot and efi bootinfo.c files are now tiny.
This could use some more refactoring, but this is a working checkpoint.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49436
Build 46326: arc lint + arc unit

Event Timeline

imp created this revision.Feb 1 2023, 11:15 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 1 2023, 11:15 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

imp requested review of this revision.Feb 1 2023, 11:15 PM

Harbormaster completed remote builds in B49436: Diff 116240.Feb 1 2023, 11:15 PM

imp added a parent revision: D38319: kboot: Probe all disks and partitions for a kernel.Feb 1 2023, 11:21 PM

rebase / refactor / redo

Harbormaster completed remote builds in B49451: Diff 116257.Feb 1 2023, 11:25 PM

Maybe it should be moved to common?

This revision is now accepted and ready to land.Feb 2 2023, 12:31 PM

In D38350#871484, @tsoome wrote:

Maybe it should be moved to common?

No. Not yet. It can't be used for anything else.

In D38350#871512, @imp wrote:

In D38350#871484, @tsoome wrote:

Maybe it should be moved to common?

No. Not yet. It can't be used for anything else.

We have three different ones of these, reflecting a diverse history of FreeBSD... Refactoring them to be one common thing should be undertaken, but we're not yet there. This is one step in that process.

Closed by commit rG0928550c3e17: stand: share bootinfo.c between EFI and KBOOT (authored by imp). · Explain WhyFeb 3 2023, 3:52 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG0928550c3e17: stand: share bootinfo.c between EFI and KBOOT.