bhyve: Remove vmctx member from struct vm_snapshot_meta.
ClosedPublic
Actions

Authored by jhb on Jan 19 2023, 6:31 PM.

Details

Reviewers

corvink
markj

Group Reviewers

bhyve

Commits

rG0f735657aa76: bhyve: Remove vmctx member from struct vm_snapshot_meta.

Summary

This is a userland-only pointer that isn't relevant to the kernel and
doesn't belong in the ioctl structure shared between userland and the
kernel. For the kernel, the old structure for the ioctl is still
supported under COMPAT_FREEBSD13.

This changes vm_snapshot_req() in libvmmapi to accept an explicit
vmctx argument.

It also changes vm_snapshot_guest2host_addr to take an explicit vmctx
argument. As part of this change, move the declaration for this
function and its wrapper macro from vmm_snapshot.h to snapshot.h as it
is a userland-only API.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49171
Build 46060: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 19 2023, 6:31 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJan 19 2023, 6:31 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Jan 19 2023, 6:31 PM

jhb added a parent revision: D38124: libvmmapi: Add a struct vcpu and use it in most APIs..

Harbormaster completed remote builds in B49171: Diff 115325.Jan 19 2023, 6:31 PM

corvink accepted this revision.Jan 20 2023, 6:51 AM

This revision is now accepted and ready to land.Jan 20 2023, 6:51 AM

For the kernel, the old structure for the ioctl is still supported under COMPAT_FREEBSD13.

Do we really care about preserving compatibility for a feature that isn't compiled in (in userspace anyway) by default? Since you already did the work then I guess it might as well stay but it seems unnecessary.

In D38125#866342, @markj wrote:

For the kernel, the old structure for the ioctl is still supported under COMPAT_FREEBSD13.

Do we really care about preserving compatibility for a feature that isn't compiled in (in userspace anyway) by default? Since you already did the work then I guess it might as well stay but it seems unnecessary.

I think we probably mostly don't, but it was cheap to add.