ifnet/API: Change if_set*bit accessors to clear first
ClosedPublic
Actions

Authored by jhibbits on Jan 9 2023, 7:22 PM.

Details

Reviewers

glebius
melifaro

Group Reviewers

network

Commits

rGd34678395f3f: ifnet/API: Change if_set*bit accessors to clear first

Summary

A common pattern has been to:

if (foo)

		caps = IFCAP_FOO;

ifp->if_capenable &= ~IFCAP_FOO;
ifp->if_capenable |= caps;

which in the new order of things would be:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, 0, IFCAP_FOO);
if_setcapenablebits(ifp, caps, 0);

This change streamlines this into:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, caps, IFCAP_FOO);

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Jan 9 2023, 7:22 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJan 9 2023, 7:22 PM

jhibbits requested review of this revision.Jan 9 2023, 7:22 PM

Harbormaster completed remote builds in B49002: Diff 114879.Jan 9 2023, 7:23 PM

melifaro accepted this revision as: melifaro.Jan 9 2023, 8:09 PM

This revision is now accepted and ready to land.Jan 9 2023, 8:09 PM

Closed by commit rGd34678395f3f: ifnet/API: Change if_set*bit accessors to clear first (authored by jhibbits). · Explain WhyJan 9 2023, 8:55 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rGd34678395f3f: ifnet/API: Change if_set*bit accessors to clear first.

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

12 lines

Diff 114904

View Options

ifnet/API: Change if_set*bit accessors to clear firstClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 114904

sys/net/if.c

ifnet/API: Change if_set*bit accessors to clear first
ClosedPublic
Actions

Revision Contents
Changeset List