Page MenuHomeFreeBSD
Differential D37166

vmm: Remove unused vcpuid argument from vioapic_process_eoi.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 12:51 AM
Unknown Object (File)
Sat, Apr 5, 1:27 PM
Unknown Object (File)
Mar 19 2025, 12:07 PM
Unknown Object (File)
Feb 22 2025, 2:25 PM
Unknown Object (File)
Feb 22 2025, 2:06 PM
Unknown Object (File)
Feb 22 2025, 1:55 PM
Unknown Object (File)
Feb 22 2025, 1:52 PM
Unknown Object (File)
Jan 6 2025, 10:29 PM
View All 88 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
markj
corvink
Group Reviewers
bhyve
Commits
rG9ed7e7c69e1a: vmm: Remove unused vcpuid argument from vioapic_process_eoi.
rGe42c24d56b3d: vmm: Remove unused vcpuid argument from vioapic_process_eoi.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
io/
2 lines
2 lines
3 lines
3 lines

Diff 113307

View Options

sys/amd64/vmm/io/vioapic.h

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines case LINUX_SYS_linux_clock_nanosleep:
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break; break;
case LINUX_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
emasteUnsubmitted
Not Done
Inline Actions

FWIW most (but not all) existing cases seem to follow the pattern

		c = ',';
		ip++;
		narg--;

(i.e., setting 'c' first)

emaste: FWIW most (but not all) existing cases seem to follow the pattern ``` c = ','; ip++; narg…
break;
case LINUX_SYS_linux_kill: case LINUX_SYS_linux_kill:
case LINUX_SYS_linux_tkill: case LINUX_SYS_linux_tkill:
case LINUX_SYS_linux_rt_sigqueueinfo: case LINUX_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
narg--; narg--;
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines case LINUX32_SYS_linux_clock_nanosleep:
sysdecode_linux_clockid(stdout, *ip); sysdecode_linux_clockid(stdout, *ip);
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break;
case LINUX32_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
break; break;
case LINUX32_SYS_linux_kill: case LINUX32_SYS_linux_kill:
case LINUX32_SYS_linux_tkill: case LINUX32_SYS_linux_tkill:
case LINUX32_SYS_linux_rt_sigqueueinfo: case LINUX32_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines
View Options

sys/amd64/vmm/io/vioapic.c

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines case LINUX_SYS_linux_clock_nanosleep:
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break; break;
case LINUX_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
emasteUnsubmitted
Not Done
Inline Actions

FWIW most (but not all) existing cases seem to follow the pattern

		c = ',';
		ip++;
		narg--;

(i.e., setting 'c' first)

emaste: FWIW most (but not all) existing cases seem to follow the pattern ``` c = ','; ip++; narg…
break;
case LINUX_SYS_linux_kill: case LINUX_SYS_linux_kill:
case LINUX_SYS_linux_tkill: case LINUX_SYS_linux_tkill:
case LINUX_SYS_linux_rt_sigqueueinfo: case LINUX_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
narg--; narg--;
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines case LINUX32_SYS_linux_clock_nanosleep:
sysdecode_linux_clockid(stdout, *ip); sysdecode_linux_clockid(stdout, *ip);
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break;
case LINUX32_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
break; break;
case LINUX32_SYS_linux_kill: case LINUX32_SYS_linux_kill:
case LINUX32_SYS_linux_tkill: case LINUX32_SYS_linux_tkill:
case LINUX32_SYS_linux_rt_sigqueueinfo: case LINUX32_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines
View Options

sys/amd64/vmm/io/vlapic.c

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines case LINUX_SYS_linux_clock_nanosleep:
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break; break;
case LINUX_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
emasteUnsubmitted
Not Done
Inline Actions

FWIW most (but not all) existing cases seem to follow the pattern

		c = ',';
		ip++;
		narg--;

(i.e., setting 'c' first)

emaste: FWIW most (but not all) existing cases seem to follow the pattern ``` c = ','; ip++; narg…
break;
case LINUX_SYS_linux_kill: case LINUX_SYS_linux_kill:
case LINUX_SYS_linux_tkill: case LINUX_SYS_linux_tkill:
case LINUX_SYS_linux_rt_sigqueueinfo: case LINUX_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
narg--; narg--;
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines case LINUX32_SYS_linux_clock_nanosleep:
sysdecode_linux_clockid(stdout, *ip); sysdecode_linux_clockid(stdout, *ip);
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break;
case LINUX32_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
break; break;
case LINUX32_SYS_linux_kill: case LINUX32_SYS_linux_kill:
case LINUX32_SYS_linux_tkill: case LINUX32_SYS_linux_tkill:
case LINUX32_SYS_linux_rt_sigqueueinfo: case LINUX32_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines
View Options

sys/amd64/vmm/vmm.c

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines case LINUX_SYS_linux_clock_nanosleep:
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break; break;
case LINUX_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
emasteUnsubmitted
Not Done
Inline Actions

FWIW most (but not all) existing cases seem to follow the pattern

		c = ',';
		ip++;
		narg--;

(i.e., setting 'c' first)

emaste: FWIW most (but not all) existing cases seem to follow the pattern ``` c = ','; ip++; narg…
break;
case LINUX_SYS_linux_kill: case LINUX_SYS_linux_kill:
case LINUX_SYS_linux_tkill: case LINUX_SYS_linux_tkill:
case LINUX_SYS_linux_rt_sigqueueinfo: case LINUX_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
narg--; narg--;
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines case LINUX32_SYS_linux_clock_nanosleep:
sysdecode_linux_clockid(stdout, *ip); sysdecode_linux_clockid(stdout, *ip);
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break;
case LINUX32_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
break; break;
case LINUX32_SYS_linux_kill: case LINUX32_SYS_linux_kill:
case LINUX32_SYS_linux_tkill: case LINUX32_SYS_linux_tkill:
case LINUX32_SYS_linux_rt_sigqueueinfo: case LINUX32_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines