Differential D35812
Makefile.inc1: Set LC_COLLATE in distributeworld for glibc compatibility Authored by jrtc27 on Jul 14 2022, 12:13 AM. Tags None Referenced Files
Subscribers None
Details distributeworld relies on "foo" sorting directly before "foo type=...", Obtained from: CheriBSD
Diff Detail
Event TimelineComment Actions It looks like we use LC_COLLATE=C sort elsewhere in this file. I wonder if the comments should reflect the use of LC_*=C. I also wonder if we shouldn't just have a SORTCMD=LC_COLLATE=C sort that we use in place of bare sort Comment Actions LC_COLLATE=C isn't sufficient in the case LC_ALL is set in the (user's/server's) environment and is probably why I picked LC_ALL=C instead, but that's addressed elsewhere by env -i. There are a bunch of other places that run sort without setting LC_COLLATE and I don't think they really matter, so I'd rather leave those alone. Currently testing whether env -i LC_COLLATE=C works or there's something I've forgotten in the few months since I originally wrote this for CheriBSD. Comment Actions Switch to env -i LC_COLLATE=C and pull out existing copies of the pattern to a common variable |