Page MenuHomeFreeBSD
Differential D33573

bhyve nvme: Update v1.4 Identify Controller data
ClosedPublic
Actions

Authored by chuck on Dec 19 2021, 4:17 PM.
Tags
None
Referenced Files
F157373332: D33573.id102085.diff
Wed, May 20, 6:10 PM
Unknown Object (File)
Wed, May 20, 7:54 AM
Unknown Object (File)
Wed, May 20, 7:52 AM
Unknown Object (File)
Sun, May 17, 9:23 AM
Unknown Object (File)
Fri, May 8, 6:43 PM
Unknown Object (File)
Fri, May 1, 9:47 PM
Unknown Object (File)
Tue, Apr 28, 11:58 AM
Unknown Object (File)
Fri, Apr 24, 6:12 PM
View All Files
Subscribers
allanjude
bcran
dab
rgrimes

Details

Reviewers
grehan
jhb
imp
rpokala
allanjude
Group Reviewers
bhyve
Commits
rG29241c96f75b: bhyve nvme: Update v1.4 Identify Controller data
Summary

Compliant v1.4 Controllers must report a Controller Type (CNTRLTYPE) and
Sanitize Capabilities (SANICAP).

Fixes UNH ILO Test 1.1, Case 2

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44161
Build 41049: arc lint + arc unit

Event Timeline

chuck created this revision.Dec 19 2021, 4:17 PM
Herald added a reviewer: bhyve. · View Herald TranscriptDec 19 2021, 4:17 PM
Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript
chuck requested review of this revision.Dec 19 2021, 4:17 PM
Harbormaster completed remote builds in B43486: Diff 100302.Dec 19 2021, 4:17 PM
chuck added a parent revision: D33572: bhyve nvme: Add Temperature Threshold support.Dec 19 2021, 4:17 PM
chuck added a child revision: D33574: bhyve nvme: Add Select support to Get Features.
allanjude accepted this revision.Dec 23 2021, 5:15 PM
allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:15 PM
imp accepted this revision.Dec 23 2021, 7:23 PM
chuck updated this revision to Diff 102085.Jan 29 2022, 8:56 PM

NVMe compliance test is wrong, thus dropping SANICAP changes.
Also, don't advertise secure erase

This revision now requires review to proceed.Jan 29 2022, 8:56 PM
Harbormaster completed remote builds in B44161: Diff 102085.Jan 29 2022, 8:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2022, 11:18 PM
Closed by commit rG29241c96f75b: bhyve nvme: Update v1.4 Identify Controller data (authored by chuck). · Explain Why
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rG29241c96f75b: bhyve nvme: Update v1.4 Identify Controller data.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
10 lines

Diff 102085

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...