Page MenuHomeFreeBSD
Differential D59438

Introduce nfsdtop(8)
ClosedPublic
Actions

Authored by dteske on Sat, Sep 5, 2:40 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 1, 3:08 PM
Unknown Object (File)
Wed, Sep 30, 6:10 AM
Unknown Object (File)
Wed, Sep 23, 11:42 AM
Unknown Object (File)
Wed, Sep 23, 1:55 AM
Unknown Object (File)
Tue, Sep 22, 11:15 PM
Unknown Object (File)
Sun, Sep 20, 1:33 PM
Unknown Object (File)
Sat, Sep 19, 1:34 PM
Unknown Object (File)
Fri, Sep 18, 11:54 PM
View All 40 Files
Subscribers
bcr
imp
rmacklem
ziaee

Details

Reviewers
adrian
emaste
markj
ziaee
bcr
rmacklem
Commits
rG60c7313074b9: Introduce nfsdtop(8)
Summary

Display top-like NFS server I/O using dtrace(1).
Also supports JSON output for time-series.

Relnotes: yes

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dteske created this revision.Sat, Sep 5, 2:40 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Sep 5, 2:40 AM
dteske requested review of this revision.Sat, Sep 5, 2:40 AM
Harbormaster completed remote builds in B76559: Diff 185909.Sat, Sep 5, 2:40 AM
dteske added reviewers: adrian, emaste, rmacklem, markj, ziaee.Sat, Sep 5, 2:45 AM
dteske added projects: DTrace, manpages.
rmacklem resigned from this revision.Sat, Sep 5, 3:04 AM

Looks good, but I'm no shell script guy, so hopefully
someone else can review it.

Thanks for doing this, rick

bcr accepted this revision.Sat, Sep 5, 7:35 AM
bcr added a subscriber: bcr.

OK for the man page part.

This revision is now accepted and ready to land.Sat, Sep 5, 7:35 AM
ziaee accepted this revision.Sat, Sep 5, 1:52 PM

Manpage looks great, thanks for tagging me!

usr.sbin/nfsdtop/nfsdtop.8
308

Thank you for documenting known limitations in conformance with the mdoc standards. I know this is contentious and it means a lot.

adrian accepted this revision.Sat, Sep 5, 3:59 PM
dteske marked an inline comment as done.Sun, Sep 6, 5:50 PM
dteske added inline comments.
usr.sbin/nfsdtop/nfsdtop.8
308

You are very welcome.

dteske marked an inline comment as done.Sun, Sep 6, 5:55 PM
dteske added a subscriber: rmacklem.
In D59438#1363257, @rmacklem wrote:

Looks good, but I'm no shell script guy, so hopefully
someone else can review it.

Thanks for doing this, rick

You are very welcome, and thanks for the "Looks good" (was hard work -- written in 2020 and not changed once since except to add a man-page and switch out the long-form license for an SPDX identifier, and drop the vim/emacs hints)

dteske added a comment.Sun, Sep 6, 5:56 PM

Thanks all for the review.

Closed by commit rG60c7313074b9: Introduce nfsdtop(8) (authored by dteske). · Explain WhySun, Sep 6, 10:37 PM
This revision was automatically updated to reflect the committed changes.
dteske added a commit: rG60c7313074b9: Introduce nfsdtop(8).

Revision Contents
Changeset List

PathSize
usr.sbin/
1 line
nfsdtop/
6 lines
1565 lines
310 lines

Diff 186082

View Options

usr.sbin/Makefile

Loading...
View Options

usr.sbin/nfsdtop/Makefile

Loading...
View Options

usr.sbin/nfsdtop/nfsdtop

Loading...
View Options

usr.sbin/nfsdtop/nfsdtop.8

Loading...