bhyve: document missing options in bhyve_config(5)
AcceptedPublic
Actions

Authored by novel on Wed, Jul 22, 5:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 2, 6:38 PM

	Unknown Object (File)
	Sun, Aug 2, 4:51 AM

	Unknown Object (File)
	Sat, Aug 1, 5:33 PM

	Unknown Object (File)
	Sat, Aug 1, 8:20 AM

	Unknown Object (File)
	Fri, Jul 31, 5:34 AM

	Unknown Object (File)
	Thu, Jul 30, 8:39 PM

	Unknown Object (File)
	Thu, Jul 30, 10:35 AM

	Unknown Object (File)
	Thu, Jul 30, 8:37 AM

Subscribers

Details

Reviewers

bnovkov

Group Reviewers

bhyve
manpages

Summary

Document a few options that are currently supported but
not covered in bhyve_config(5):

monitor
vcpu.N.cpuset
domains.N.{size,cpus,domain_policy}
console (for arm64 and riscv)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75020
Build 71903: arc lint + arc unit

Event Timeline

novel created this revision.Wed, Jul 22, 5:38 PM

Herald added a reviewer: bhyve. · View Herald TranscriptWed, Jul 22, 5:38 PM

Herald added subscribers: ziaee, bcran, rgrimes, imp. · View Herald Transcript

novel requested review of this revision.Wed, Jul 22, 5:38 PM

Harbormaster completed remote builds in B75020: Diff 182473.Wed, Jul 22, 5:38 PM

novel added a reviewer: manpages.Wed, Jul 22, 5:39 PM

In general this looks decent to me though I haven't reviewed it in detail. @bnovkov, does the vCPU pinning stuff and NUMA stuff look correct?

LGTM, but I'd wait for at least one member of manpages to take a look.

In D58399#1343412, @jhb wrote:

In general this looks decent to me though I haven't reviewed it in detail. @bnovkov, does the vCPU pinning stuff and NUMA stuff look correct?

Yes, these look alright.

This revision is now accepted and ready to land.Fri, Jul 31, 3:06 PM

@bcr @ziaee could you possibly take a look?

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

bhyve_config.5

51 lines

Diff 182473

View Options

usr.sbin/bhyve/bhyve_config.5

bhyve: document missing options in bhyve_config(5)AcceptedPublicActions