bhyve: document missing options in bhyve_config(5)
ClosedPublic
Actions

Authored by novel on Wed, Jul 22, 5:38 PM.

Details

Reviewers

Group Reviewers

bhyve
manpages

Commits

rGa257e2dc9c6e: bhyve: document missing options in bhyve_config(5)

Summary

Document a few options that are currently supported but
not covered in bhyve_config(5):

monitor
vcpu.N.cpuset
domains.N.{size,cpus,domain_policy}
console (for arm64 and riscv)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

novel created this revision.Wed, Jul 22, 5:38 PM

Herald added a reviewer: bhyve. · View Herald TranscriptWed, Jul 22, 5:38 PM

Herald added subscribers: ziaee, bcran, rgrimes, imp. · View Herald Transcript

novel requested review of this revision.Wed, Jul 22, 5:38 PM

Harbormaster completed remote builds in B75020: Diff 182473.Wed, Jul 22, 5:38 PM

novel added a reviewer: manpages.Wed, Jul 22, 5:39 PM

In general this looks decent to me though I haven't reviewed it in detail. @bnovkov, does the vCPU pinning stuff and NUMA stuff look correct?

LGTM, but I'd wait for at least one member of manpages to take a look.

In D58399#1343412, @jhb wrote:

In general this looks decent to me though I haven't reviewed it in detail. @bnovkov, does the vCPU pinning stuff and NUMA stuff look correct?

Yes, these look alright.

This revision is now accepted and ready to land.Fri, Jul 31, 3:06 PM

@bcr @ziaee could you possibly take a look?

manpages ping

Closed by commit rGa257e2dc9c6e: bhyve: document missing options in bhyve_config(5) (authored by novel). · Explain WhyFri, Aug 14, 4:00 PM

This revision was automatically updated to reflect the committed changes.

novel added a commit: rGa257e2dc9c6e: bhyve: document missing options in bhyve_config(5).

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

bhyve_config.5

51 lines

Diff 184057

View Options

usr.sbin/bhyve/bhyve_config.5

bhyve: document missing options in bhyve_config(5)ClosedPublicActions