Page MenuHomeFreeBSD
Differential D56714

Makefile.inc1: Don't unnecessarily ignore rm errors
ClosedPublic
Actions

Authored by emaste on Apr 29 2026, 6:09 PM.
Tags
None
Referenced Files
F175329847: D56714.id176818.diff
Sat, Oct 10, 12:54 AM
F175286954: D56714.id189250.diff
Fri, Oct 9, 4:53 PM
F175286831: D56714.id.diff
Fri, Oct 9, 4:52 PM
F175286782: D56714.diff
Fri, Oct 9, 4:52 PM
Unknown Object (File)
Sun, Sep 20, 3:38 AM
Unknown Object (File)
Fri, Sep 11, 9:10 AM
Unknown Object (File)
Sep 6 2026, 11:06 AM
Unknown Object (File)
Sep 5 2026, 5:10 PM
View All 46 Files
Subscribers
imp

Details

Reviewers
brooks
adrian
Group Reviewers
build
releng
Commits
rGd3c788feec4c: Makefile.inc1: Don't unnecessarily ignore rm errors
Summary
For rm -f it's not an error if the files do not exist.  If there's any
other error it's presumably a real issue, so avoid ignoring all errors.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Apr 29 2026, 6:09 PM
emaste created this revision.
brooks accepted this revision.Fri, Oct 9, 2:50 PM
This revision is now accepted and ready to land.Fri, Oct 9, 2:50 PM
adrian accepted this revision.Fri, Oct 9, 3:05 PM
emaste added inline comments.Fri, Oct 9, 3:09 PM
Makefile.inc1
2272

I believe this is the first instance of this, from 9269ba461b03c.

Closed by commit rGd3c788feec4c: Makefile.inc1: Don't unnecessarily ignore rm errors (authored by emaste). · Explain WhyFri, Oct 9, 3:10 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGd3c788feec4c: Makefile.inc1: Don't unnecessarily ignore rm errors.
Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 3:10 PM

Revision Contents
Changeset List

PathSize
8 lines

Diff 189250

View Options

Makefile.inc1

Loading...