Paths

Table of Contentst

Differential D56650

acpi: Remove userland bits on non-ACPI platforms
ClosedPublic
Actions

Authored by ivy on Sun, Apr 26, 10:17 PM.

Tags

None

Referenced Files

	F156959958: D56650.id176757.diff
	Sun, May 17, 4:04 PM

	F156959582: D56650.id176757.diff
	Sun, May 17, 4:01 PM

	Unknown Object (File)
	Thu, May 14, 3:23 PM

	Unknown Object (File)
	Thu, May 14, 12:51 PM

	Unknown Object (File)
	Thu, May 14, 7:29 AM

	Unknown Object (File)
	Sun, May 10, 10:34 PM

	Unknown Object (File)
	Sun, May 10, 6:26 PM

	Unknown Object (File)
	Fri, May 8, 4:54 AM

View All 23 Files

Subscribers

Details

Reviewers

jhb
kib
imp
andrew

Group Reviewers

Commits

rGc4b244af42a1: acpi: Remove userland bits on non-ACPI platforms

Summary

ACPI is only supported on amd64, arm64 and i386. Don't install the
power_profile rc script or devd configuration on other platforms.

This avoids creating a useless FreeBSD-acpi package on those platforms.

MFC after: 2 weeks
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Sun, Apr 26, 10:17 PM

Herald added a reviewer: andrew. · View Herald TranscriptSun, Apr 26, 10:17 PM

Herald added a subscriber: asomers. · View Herald Transcript

ivy requested review of this revision.Sun, Apr 26, 10:17 PM

Harbormaster completed remote builds in B72558: Diff 176588.Sun, Apr 26, 10:17 PM

imp added inline comments.Sun, Apr 26, 10:30 PM

libexec/rc/rc.d/Makefile
92	I thought armv7 also did ACPI. Am I mistaken?

ivy added inline comments.Sun, Apr 26, 10:46 PM

libexec/rc/rc.d/Makefile
92	we don't ship the other ACPI userland bits on armv7 (see usr.sbin/Makefile.*), and none of the kernel configs in sys/arm/conf include `device acpi`, so it doesn't currently seem to be supported.

This looks great!

libexec/rc/rc.d/Makefile
92	Ah! We share some files between armv7 and aarch64 that have ACPI in them. And while we boot with UEFI, we don't use ACPI on armv7. So I am mistaken on this.

This revision is now accepted and ready to land.Mon, Apr 27, 12:33 AM

Closed by commit rGc4b244af42a1: acpi: Remove userland bits on non-ACPI platforms (authored by ivy). · Explain WhyTue, Apr 28, 7:51 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGc4b244af42a1: acpi: Remove userland bits on non-ACPI platforms.

Revision Contents
Changeset List

Path

Size

libexec/

rc/

rc.d/

3 lines

packages/

Makefile.powerpc

Makefile.riscv64

1 line

acpi/

6 lines

sbin/

devd/

3 lines

tools/

build/

mk/

OptionalObsoleteFiles.inc

4 lines

Diff 176757

libexec/rc/rc.d/Makefile

Loading...

packages/Makefile.arm

Loading...

packages/Makefile.powerpc

Loading...

packages/Makefile.riscv64

Loading...

packages/acpi/Makefile

Loading...

sbin/devd/Makefile

Loading...

tools/build/mk/OptionalObsoleteFiles.inc

Loading...