Differential D56225

rc.conf.5: Document virtual_oss(8)
ClosedPublic
Actions

Authored by christos on Thu, Apr 2, 5:09 PM.

Tags

None

Referenced Files

	F154356434: D56225.diff
	Tue, Apr 28, 1:48 AM

	F154330109: D56225.id174811.diff
	Mon, Apr 27, 9:34 PM

	F154298738: D56225.id174813.diff
	Mon, Apr 27, 4:46 PM

	Unknown Object (File)
	Tue, Apr 21, 5:26 AM

	Unknown Object (File)
	Mon, Apr 20, 11:41 PM

	Unknown Object (File)
	Sat, Apr 18, 11:54 AM

	Unknown Object (File)
	Sat, Apr 18, 11:39 AM

	Unknown Object (File)
	Sat, Apr 18, 11:39 AM

View All 21 Files

Subscribers

Details

Reviewers

markj
emaste
ziaee
meka_tilda.center

Commits

rGc93b81369b8a: rc.conf.5: Document virtual_oss(8)
rGa3094f522fec: rc.conf.5: Document virtual_oss(8)

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Thu, Apr 2, 5:09 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Apr 2, 5:09 PM

christos requested review of this revision.Thu, Apr 2, 5:09 PM

Harbormaster completed remote builds in B71918: Diff 174811.Thu, Apr 2, 5:09 PM

christos added a reviewer: meka_tilda.center.Thu, Apr 2, 5:10 PM

christos added a parent revision: D55670: virtual_oss: Introduce virtual_oss_default_control_device rc variable.Thu, Apr 2, 5:14 PM

Clarify virtual_oss_default_control_device further.

Harbormaster completed remote builds in B71919: Diff 174813.Thu, Apr 2, 5:54 PM

markj added inline comments.Fri, Apr 3, 7:46 AM

share/man/man5/rc.conf.5
4975
5000	The use of "override" to mean "set an rc.conf variable" sounds strange. I think these uses of that word should be replaced by plain "set" or "set in rc.conf".

christos marked an inline comment as done.Fri, Apr 3, 2:15 PM

christos added inline comments.

share/man/man5/rc.conf.5
5000	No objection to this. The reason I used "override" is because these variables are set in rc.conf, but by libexec/rc/rc.d/virtual_oss, so I guess we technically do have to override them. There is similar wording in the "SERVICE JAILS" section: Typically this variable is set inside rc scripts, but it can be overridden in the rc config.

christos added inline comments.Tue, Apr 14, 11:00 AM

share/man/man5/rc.conf.5
5000	Bump.

markj added inline comments.Wed, Apr 15, 3:09 PM

share/man/man5/rc.conf.5
5000	I still think "set" is more clear. The documentation describes how to override default configuration by setting rc.conf variables.

Address Mark's comments.

Harbormaster completed remote builds in B72230: Diff 175575.Wed, Apr 15, 3:12 PM

Fix.

Harbormaster completed remote builds in B72231: Diff 175576.Wed, Apr 15, 3:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Apr 16, 2:51 PM

Closed by commit rGa3094f522fec: rc.conf.5: Document virtual_oss(8) (authored by christos). · Explain Why

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGa3094f522fec: rc.conf.5: Document virtual_oss(8).

christos added a commit: rGc93b81369b8a: rc.conf.5: Document virtual_oss(8).Thu, Apr 23, 8:41 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man5/

57 lines

Diff 175638

share/man/man5/rc.conf.5

Loading...