Differential D56225

rc.conf.5: Document virtual_oss(8)
Needs ReviewPublic
Actions

Authored by christos on Thu, Apr 2, 5:09 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

markj
emaste
ziaee
meka_tilda.center

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71919
Build 68802: arc lint + arc unit

Event Timeline

christos created this revision.Thu, Apr 2, 5:09 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Apr 2, 5:09 PM

christos requested review of this revision.Thu, Apr 2, 5:09 PM

Harbormaster completed remote builds in B71918: Diff 174811.Thu, Apr 2, 5:09 PM

christos added a reviewer: meka_tilda.center.Thu, Apr 2, 5:10 PM

christos added a parent revision: D55670: virtual_oss: Introduce virtual_oss_default_control_device rc variable.Thu, Apr 2, 5:14 PM

Clarify virtual_oss_default_control_device further.

Harbormaster completed remote builds in B71919: Diff 174813.Thu, Apr 2, 5:54 PM

markj added inline comments.Fri, Apr 3, 7:46 AM

share/man/man5/rc.conf.5
4975
5000	The use of "override" to mean "set an rc.conf variable" sounds strange. I think these uses of that word should be replaced by plain "set" or "set in rc.conf".

christos marked an inline comment as done.Fri, Apr 3, 2:15 PM

christos added inline comments.

share/man/man5/rc.conf.5
5000	No objection to this. The reason I used "override" is because these variables are set in rc.conf, but by libexec/rc/rc.d/virtual_oss, so I guess we technically do have to override them. There is similar wording in the "SERVICE JAILS" section: Typically this variable is set inside rc scripts, but it can be overridden in the rc config.

Revision Contents
Changeset List

Path

Size

share/

man/

man5/

57 lines

Diff 174813

share/man/man5/rc.conf.5

Loading...