Page MenuHomeFreeBSD

nd6: Remove anycast check in prelist_update
ClosedPublic

Authored by pouria on Sat, Mar 28, 8:13 PM.
Tags
None
Referenced Files
F153273185: D56134.id175798.diff
Mon, Apr 20, 4:36 AM
Unknown Object (File)
Sun, Apr 19, 12:22 AM
Unknown Object (File)
Fri, Apr 17, 1:02 PM
Unknown Object (File)
Fri, Apr 17, 12:39 PM
Unknown Object (File)
Wed, Apr 15, 1:04 AM
Unknown Object (File)
Tue, Apr 14, 1:47 PM
Unknown Object (File)
Tue, Apr 14, 3:01 AM
Unknown Object (File)
Sun, Apr 12, 4:03 PM

Details

Summary

RFC 2462 is obsoleted by RFC 4862 and it made statements more clear
than before.
Considering SLAAC can't create anycast addresses by itself, remove its check.
While here, update comments based on RFC 4862.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Wed, Apr 1, 12:44 PM
zlei added a subscriber: zlei.

Looks sane to me.

For the commit message,

ndp: Remove anycast check in prelist_update

I think the word ndp is a bit misleading. I read it this is a change for the userspace one usr.sbin/ndp. I'd prefer nd6_rtr: xxx or nd6: xxx, to indicate the change is for the kernel part.

I think the word ndp is a bit misleading. I read it this is a change for the userspace one usr.sbin/ndp. I'd prefer nd6_rtr: xxx or nd6: xxx, to indicate the change is for the kernel part.

Yep. Unfortunately there is little consistency in the history of this file and of nd6.c as well. I'd suggest in the future to stick to nd6: or netinet6: if the change is touching more than just ND part of IPv6.

For the commit message,

ndp: Remove anycast check in prelist_update

I think the word ndp is a bit misleading. I read it this is a change for the userspace one usr.sbin/ndp. I'd prefer nd6_rtr: xxx or nd6: xxx, to indicate the change is for the kernel part.

Thank you for your review, I'll change I commit messages to nd6:

pouria retitled this revision from ndp: Remove anycast check in prelist_update to nd6: Remove anycast check in prelist_update.Wed, Apr 1, 4:06 PM
This revision was automatically updated to reflect the committed changes.