Page MenuHomeFreeBSD
Differential D56130

nd6: break nd6_prefix_update out of prelist_update
ClosedPublic
Actions

Authored by pouria on Sat, Mar 28, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 17, 12:39 PM
Unknown Object (File)
Tue, Apr 14, 6:16 PM
Unknown Object (File)
Sun, Apr 12, 6:21 AM
Unknown Object (File)
Sat, Apr 11, 8:05 PM
Unknown Object (File)
Sat, Apr 11, 1:15 PM
Unknown Object (File)
Thu, Apr 9, 1:53 PM
Unknown Object (File)
Thu, Apr 9, 12:10 PM
Unknown Object (File)
Wed, Apr 8, 10:00 AM
View All 17 Files
Subscribers
ae
imp
melifaro

Details

Reviewers
markj
glebius
bz
Group Reviewers
network
Commits
rGd96e8cb4e728: nd6: Break nd6_prefix_update out of prelist_update
Summary

if PI exists, call prefix_update, instead of doing it inside the prelist_update.
no functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pouria created this revision.Sat, Mar 28, 8:13 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSat, Mar 28, 8:13 PM
pouria requested review of this revision.Sat, Mar 28, 8:13 PM
Harbormaster completed remote builds in B71778: Diff 174454.Sat, Mar 28, 8:13 PM
pouria added a child revision: D56131: nd6: break pfxrtr_add out of nd6_prelist_add.Sat, Mar 28, 8:13 PM
pouria added a comment.Sat, Mar 28, 8:27 PM

For reviewers:
The whole revision stack will reduce PI code complexity and fix multiple issues along the way.
I also wrote additional tests in D56128 to make sure everything works as intended.

markj added inline comments.Sun, Mar 29, 7:14 AM
sys/netinet6/nd6_rtr.c
1552

Before, prelist_update() would return the value of error in this case. Now it does not. Is it intentional?

markj accepted this revision.Sun, Mar 29, 7:16 AM
markj added inline comments.
sys/netinet6/nd6_rtr.c
1552

After D54132 it does not matter, okay.

This revision is now accepted and ready to land.Sun, Mar 29, 7:16 AM
pouria marked 2 inline comments as done.Sun, Mar 29, 10:52 AM
pouria added inline comments.
sys/netinet6/nd6_rtr.c
1552

*D56132. Thanks!

ae added a comment.Sun, Mar 29, 3:28 PM
In D56130#1283954, @pouria wrote:

For reviewers:
The whole revision stack will reduce PI code complexity and fix multiple issues along the way.
I also wrote additional tests in D56128 to make sure everything works as intended.

Can you show what issues you are talking about?
I also have the patch related to prefixes and CARP.

pouria marked an inline comment as done.Tue, Mar 31, 8:45 PM
In D56130#1284183, @ae wrote:

Can you show what issues you are talking about?
I also have the patch related to prefixes and CARP.

I've mostly done cleanups and preparation for my other patches:

  • removing several unused conditions
  • broke down of a large function with ~350 lines.
  • fixes some DRY issues.

I took a quick look at your patch, I'll have multiple conflicts with it, especially because you used some reserved RA flags.

pouria retitled this revision from ndp: break nd6_prefix_update out of prelist_update to nd6: break nd6_prefix_update out of prelist_update.Wed, Apr 1, 4:06 PM
Closed by commit rGd96e8cb4e728: nd6: Break nd6_prefix_update out of prelist_update (authored by pouria). · Explain WhyFri, Apr 17, 10:59 PM
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rGd96e8cb4e728: nd6: Break nd6_prefix_update out of prelist_update.

Revision Contents
Changeset List

PathSize
sys/
netinet6/
78 lines

Diff 175794

View Options

sys/netinet6/nd6_rtr.c

Loading...