tests/netinet6: Add SLAAC and RA validation tests to ndp
ClosedPublic
Actions

Authored by pouria on Sat, Mar 28, 7:39 PM.

Details

Reviewers

markj
glebius
bz

Group Reviewers

network

Commits

rGc173f02045c8: tests/netinet6: Add SLAAC and RA validation tests to ndp

Summary

RA hop limit validation
RA source address validation
Multi router RA validation
Two hour rule RA validation
SLAAC onlink prefix switching test

Test Plan

# kyua test -k /usr/tests/Kyuafile sys/netinet6/ndp
sys/netinet6/ndp:ndp_prefix_lifetime_extend  ->  passed  [0.738s]
sys/netinet6/ndp:ndp_add_gu_success  ->  passed  [2.801s]
sys/netinet6/ndp:ndp_prefix_len_mismatch  ->  passed  [3.009s]
sys/netinet6/ndp:ndp_del_gu_success  ->  passed  [3.301s]
sys/netinet6/ndp:ndp_grand_linklayer_event  ->  passed  [5.151s]
sys/netinet6/ndp:ndp_slaac_default_route  ->  passed  [6.204s]
sys/netinet6/ndp:ndp_slaac_twohour_rule  ->  passed  [6.474s]
sys/netinet6/ndp:ndp_input_validation_src_linklocal  ->  passed  [6.798s]
sys/netinet6/ndp:ndp_multirouter_pref  ->  passed  [6.247s]
sys/netinet6/ndp:ndp_input_validation_hlim  ->  passed  [5.869s]
sys/netinet6/ndp:ndp_slaac_switch_onlink_prefix  ->  passed  [10.435s]
sys/netinet6/ndp:ndp_prefix_lifetime  ->  passed  [17.059s]

Results file id is usr_tests.20260328-193320-696702
Results saved to /root/.kyua/store/results.usr_tests.20260328-193320-696702.db

12/12 passed (0 broken, 0 failed, 0 skipped)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pouria created this revision.Sat, Mar 28, 7:39 PM

Herald added subscribers: melifaro, ae, asomers, imp. · View Herald TranscriptSat, Mar 28, 7:39 PM

pouria requested review of this revision.Sat, Mar 28, 7:39 PM

Harbormaster completed remote builds in B71776: Diff 174452.Sat, Mar 28, 7:39 PM

pouria added a parent revision: D56127: tests/netinet6: Allow ndp tests to run in parallel.Sat, Mar 28, 7:39 PM

pouria edited the test plan for this revision. (Show Details)Sat, Mar 28, 7:44 PM

pouria removed a parent revision: D56127: tests/netinet6: Allow ndp tests to run in parallel.Sat, Mar 28, 8:00 PM

pouria mentioned this in D56130: nd6: break nd6_prefix_update out of prelist_update.Sat, Mar 28, 8:27 PM

pouria added inline comments.Sat, Mar 28, 8:42 PM

tests/sys/netinet6/ndp.sh
579–581	XXX comment is for D55449 and ideally a node with multiple routers on its link should have multiple default routes with different nexthop weights.
663–672	FYI, this behavior seemed odd. we update the prefix valid lifetime in `ndp -p` when we shouldn't. However, It's not going to be a problem since we don't update the actual vltime on `ifa`.

pouria mentioned this in D55449: nd6: Add support for route information (RFC 4191).Wed, Apr 1, 1:27 PM

pouria added a child revision: D56216: tests/netinet6: Add route information option test.Wed, Apr 1, 3:45 PM

glebius added inline comments.Sun, Apr 12, 7:22 PM

tests/sys/netinet6/ndp.sh
306–311	Normal style is to keep `if` and `then` on the same line.
570	You can wait less here, e.g. 0.01. Should save on tests execution time.
630–632	Maybe provide a generic waiting function that waits for certain count of routers?

@glebius Done.

Harbormaster completed remote builds in B72157: Diff 175377.Sun, Apr 12, 8:09 PM

pouria added inline comments.Sun, Apr 12, 8:14 PM

tests/sys/netinet6/ndp.sh
630–632	Some tests need specific number of routers, some don't care and just need at least one. I've tried to write one, but it become more complex than necessary. I want to add other tests too, I'll try to generalize these later, if you're ok with that. Thank you!