nd6: Ignore entire PI if violates RFC 4862 section 5.5.3
ClosedPublic
Actions

Authored by pouria on Sat, Mar 28, 8:13 PM.

Details

Reviewers

markj
bz
ae
glebius

Group Reviewers

network

Commits

rG05f2acd34483: nd6: Ignore entire PI if violates RFC 4862 section 5.5.3

Summary

Ignore prefix information update earlier in prelist_update().
If PI is invalid or autonomous bit is unset, we better to let our
SLAAC address expire.
If we don't have any previous matching prefix, better not to create new one.
Because either our router don't want us to have one anymore, or the very
RA is malicious.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pouria created this revision.Sat, Mar 28, 8:13 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSat, Mar 28, 8:13 PM

pouria requested review of this revision.Sat, Mar 28, 8:13 PM

Harbormaster completed remote builds in B71781: Diff 174457.Sat, Mar 28, 8:13 PM

pouria added a parent revision: D56132: nd6: Change prelist_update() return type to void.Sat, Mar 28, 8:13 PM

pouria added a child revision: D56134: nd6: Remove anycast check in prelist_update.

ae accepted this revision as: ae.Sun, Mar 29, 5:00 PM

This revision is now accepted and ready to land.Sun, Mar 29, 5:00 PM

zlei added a subscriber: zlei.Sun, Mar 29, 5:46 PM

zlei added inline comments.

sys/netinet6/nd6_rtr.c
1572	Remove this stale comment as well ?
1607	The previous comment confuses me a bit. Why `pr must be non NULL at this point` ?

pouria retitled this revision from ndp: Ignore entire PI if violates RFC 4862 section 5.5.3 to nd6: Ignore entire PI if violates RFC 4862 section 5.5.3.Wed, Apr 1, 4:07 PM