The return value of prelist_update is unused.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 71780 Build 68663: arc lint + arc unit
Event Timeline
| sys/netinet6/nd6_rtr.c | ||
|---|---|---|
| 1826 | The return statement should just be removed. | |
| sys/netinet6/nd6_rtr.c | ||
|---|---|---|
| 1605 | RFC2462 -> RFC 4862. I'd recommend split that into a different review. It is not part of Change prelist_update() return type to void, but a good commit log is useful for users those use git blame to find out why this line was changed. Generally, for a commit, do one thing if possible. | |
| 1610 | New code should use uint32_t. I would keep existing code as is, given it is not part of the change lines related to Change prelist_update() return type to void, and also only change one u_int32_t -> uint32_t does not serve much value. I have ever had a plan to change them all, but there're too many usage. % grep -Er 'u_int(8|16|32)_t' sys | wc -l 51240 I abort finally, such a big change ( u_int(8|16|32)_t -> uint(8|16|32)_t ) will makes troubles when doing MFC. | |