qlnxe: Refactor setting the promiscuous and allmulti mode
ClosedPublic
Actions

Authored by zlei on Mon, Jan 26, 6:46 AM.

Details

Reviewers

Group Reviewers

Commits

rG1e2393930601: qlnxe: Refactor setting the promiscuous and allmulti mode
rG00ab0df79364: qlnxe: Refactor setting the promiscuous and allmulti mode
rGb8d2c1c36746: qlnxe: Refactor setting the promiscuous and allmulti mode
rG45b1718fadae: qlnxe: Refactor setting the promiscuous and allmulti mode

Summary

There're two entry points to set the promiscuous and allmulti mode. One
is ioctl and another is the init routine. Well they share almost the
identical logic so refactor a little to make the code clear.

While here, for the ioctl, translate the error to EINVAL to avoid
confusing the net stack.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Mon, Jan 26, 6:46 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 26, 6:46 AM

zlei requested review of this revision.Mon, Jan 26, 6:46 AM

zlei added a parent revision: D54889: qlnxev: Remove now unneeded include for opt_inet.h.Mon, Jan 26, 7:14 AM

zlei added a child revision: D54891: qlnxe: Allow tapping the tx packets.

kbowling accepted this revision.Fri, Feb 6, 6:29 AM

This revision is now accepted and ready to land.Fri, Feb 6, 6:29 AM

Closed by commit rG45b1718fadae: qlnxe: Refactor setting the promiscuous and allmulti mode (authored by zlei). · Explain WhyFri, Feb 6, 6:00 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG45b1718fadae: qlnxe: Refactor setting the promiscuous and allmulti mode.

zlei added a commit: rGb8d2c1c36746: qlnxe: Refactor setting the promiscuous and allmulti mode.Wed, Feb 11, 10:03 AM

zlei added a commit: rG00ab0df79364: qlnxe: Refactor setting the promiscuous and allmulti mode.Wed, Feb 11, 1:49 PM

cperciva added a commit: rG1e2393930601: qlnxe: Refactor setting the promiscuous and allmulti mode.Wed, Feb 11, 8:30 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlnx/

qlnxe/

qlnx_def.h

1 line

qlnx_os.c

80 lines

Diff 171363

View Options

sys/dev/qlnx/qlnxe/qlnx_def.h