Page MenuHomeFreeBSD
Differential D54884

qlnxe: Avoid memcpy with same source and destination
ClosedPublic
Actions

Authored by zlei on Jan 26 2026, 6:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 6, 11:19 PM
Unknown Object (File)
Thu, Jun 4, 5:53 AM
Unknown Object (File)
Sun, May 31, 11:20 AM
Unknown Object (File)
Fri, May 15, 11:46 AM
Unknown Object (File)
Thu, May 14, 2:48 PM
Unknown Object (File)
Thu, May 14, 7:31 AM
Unknown Object (File)
Wed, May 13, 7:37 PM
Unknown Object (File)
Tue, May 12, 5:53 PM
View All 29 Files
Subscribers
imp

Details

Reviewers
kbowling
Group Reviewers
network
Commits
rG18e4cb41e945: qlnxe: Avoid memcpy with same source and destination
rG36ebcb4f8219: qlnxe: Avoid memcpy with same source and destination
rGea1143bddbc3: qlnxe: Avoid memcpy with same source and destination
rG646218959504: qlnxe: Avoid memcpy with same source and destination
rG3aeeedc7e0dc: qlnxe: Avoid memcpy with same source and destination
Summary

In case the device is VF, qlnx_get_mac_addr() returns ha->primary_mac
hence it ends up memcpy with same source and destination. Refactor
slightly to avoid that.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Jan 26 2026, 6:22 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 26 2026, 6:22 AM
zlei requested review of this revision.Jan 26 2026, 6:22 AM
zlei added a parent revision: D54883: qlnxe: Remove a pointless copy back from the link-layer address.Jan 26 2026, 7:12 AM
zlei added a child revision: D54885: qlnxe: Fix setting unicast MAC filter of rx path.
kbowling accepted this revision.Feb 6 2026, 6:11 AM
kbowling added inline comments.
sys/dev/qlnx/qlnxe/qlnx_os.c
2328

There is an ether_gen_addr that could replace the generator here

This revision is now accepted and ready to land.Feb 6 2026, 6:11 AM
zlei added inline comments.Feb 6 2026, 7:28 AM
sys/dev/qlnx/qlnxe/qlnx_os.c
2328

Yeah, indeed.

Closed by commit rG3aeeedc7e0dc: qlnxe: Avoid memcpy with same source and destination (authored by zlei). · Explain WhyFeb 6 2026, 5:59 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG3aeeedc7e0dc: qlnxe: Avoid memcpy with same source and destination.
zlei added a commit: rG646218959504: qlnxe: Avoid memcpy with same source and destination.Feb 11 2026, 10:03 AM
zlei added a commit: rGea1143bddbc3: qlnxe: Avoid memcpy with same source and destination.Feb 11 2026, 1:49 PM
cperciva added a commit: rG36ebcb4f8219: qlnxe: Avoid memcpy with same source and destination.Feb 11 2026, 8:30 PM
zlei added a commit: rG18e4cb41e945: qlnxe: Avoid memcpy with same source and destination.Feb 24 2026, 10:46 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
qlnx/
qlnxe/
1 line
13 lines

Diff 171357

View Options

sys/dev/qlnx/qlnxe/qlnx_def.h

Loading...
View Options

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...