Page MenuHomeFreeBSD
Differential D54884

qlnxe: Avoid memcpy with same source and destination
ClosedPublic
Actions

Authored by zlei on Mon, Jan 26, 6:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 13, 4:40 PM
Unknown Object (File)
Wed, Feb 11, 7:59 PM
Unknown Object (File)
Tue, Feb 10, 6:24 AM
Unknown Object (File)
Mon, Feb 9, 2:10 PM
Unknown Object (File)
Mon, Feb 2, 9:40 PM
Unknown Object (File)
Mon, Feb 2, 3:28 AM
Unknown Object (File)
Wed, Jan 28, 2:44 AM
Unknown Object (File)
Tue, Jan 27, 7:38 PM
View All 11 Files
Subscribers
imp

Details

Reviewers
kbowling
Group Reviewers
network
Commits
rG36ebcb4f8219: qlnxe: Avoid memcpy with same source and destination
rGea1143bddbc3: qlnxe: Avoid memcpy with same source and destination
rG646218959504: qlnxe: Avoid memcpy with same source and destination
rG3aeeedc7e0dc: qlnxe: Avoid memcpy with same source and destination
Summary

In case the device is VF, qlnx_get_mac_addr() returns ha->primary_mac
hence it ends up memcpy with same source and destination. Refactor
slightly to avoid that.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Mon, Jan 26, 6:22 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 26, 6:22 AM
zlei requested review of this revision.Mon, Jan 26, 6:22 AM
zlei added a parent revision: D54883: qlnxe: Remove a pointless copy back from the link-layer address.Mon, Jan 26, 7:12 AM
zlei added a child revision: D54885: qlnxe: Fix setting unicast MAC filter of rx path.
kbowling accepted this revision.Fri, Feb 6, 6:11 AM
kbowling added inline comments.
sys/dev/qlnx/qlnxe/qlnx_os.c
2328

There is an ether_gen_addr that could replace the generator here

This revision is now accepted and ready to land.Fri, Feb 6, 6:11 AM
zlei added inline comments.Fri, Feb 6, 7:28 AM
sys/dev/qlnx/qlnxe/qlnx_os.c
2328

Yeah, indeed.

Closed by commit rG3aeeedc7e0dc: qlnxe: Avoid memcpy with same source and destination (authored by zlei). · Explain WhyFri, Feb 6, 5:59 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG3aeeedc7e0dc: qlnxe: Avoid memcpy with same source and destination.
zlei added a commit: rG646218959504: qlnxe: Avoid memcpy with same source and destination.Wed, Feb 11, 10:03 AM
zlei added a commit: rGea1143bddbc3: qlnxe: Avoid memcpy with same source and destination.Wed, Feb 11, 1:49 PM
cperciva added a commit: rG36ebcb4f8219: qlnxe: Avoid memcpy with same source and destination.Wed, Feb 11, 8:30 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
qlnx/
qlnxe/
1 line
13 lines

Diff 171357

View Options

sys/dev/qlnx/qlnxe/qlnx_def.h

Loading...
View Options

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...