Page MenuHomeFreeBSD
Differential D54883

qlnxe: Remove a pointless copy back from the link-layer address
ClosedPublic
Actions

Authored by zlei on Jan 26 2026, 6:20 AM.
Tags
None
Referenced Files
F147884408: D54883.id170437.diff
Sat, Mar 14, 10:06 AM
F147884127: D54883.id170437.diff
Sat, Mar 14, 10:03 AM
Unknown Object (File)
Fri, Mar 13, 9:24 PM
Unknown Object (File)
Fri, Mar 13, 9:24 PM
Unknown Object (File)
Tue, Mar 10, 8:01 PM
Unknown Object (File)
Fri, Feb 20, 5:05 PM
Unknown Object (File)
Sat, Feb 14, 8:08 PM
Unknown Object (File)
Sat, Feb 14, 9:55 AM
View All 19 Files
Subscribers
imp

Details

Reviewers
kbowling
Group Reviewers
network
Commits
rG59c399d38dd8: qlnxe: Remove a pointless copy back from the link-layer address
rG644486902097: qlnxe: Remove a pointless copy back from the link-layer address
rG7d7cee09b9a4: qlnxe: Remove a pointless copy back from the link-layer address
rG23ffd1650cc4: qlnxe: Remove a pointless copy back from the link-layer address
rG4ac3081b2828: qlnxe: Remove a pointless copy back from the link-layer address
Summary

On ifnet attaching, ether_ifattach() makes the link-layer address by
shadow copying the ha->primary_mac. Well the link-layer address will not
be altered during attaching, thus it is pointless to copy it back.

There should be no functional changes.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Jan 26 2026, 6:20 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 26 2026, 6:20 AM
zlei requested review of this revision.Jan 26 2026, 6:20 AM
zlei added a child revision: D54885: qlnxe: Fix setting unicast MAC filter of rx path.Jan 26 2026, 7:11 AM
zlei edited child revisions, added: D54884: qlnxe: Avoid memcpy with same source and destination; removed: D54885: qlnxe: Fix setting unicast MAC filter of rx path.
kbowling accepted this revision.Feb 6 2026, 6:07 AM
This revision is now accepted and ready to land.Feb 6 2026, 6:07 AM
Closed by commit rG4ac3081b2828: qlnxe: Remove a pointless copy back from the link-layer address (authored by zlei). · Explain WhyFeb 6 2026, 5:59 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG4ac3081b2828: qlnxe: Remove a pointless copy back from the link-layer address.
zlei added a commit: rG23ffd1650cc4: qlnxe: Remove a pointless copy back from the link-layer address.Feb 11 2026, 10:03 AM
zlei added a commit: rG7d7cee09b9a4: qlnxe: Remove a pointless copy back from the link-layer address.Feb 11 2026, 1:49 PM
cperciva added a commit: rG644486902097: qlnxe: Remove a pointless copy back from the link-layer address.Feb 11 2026, 8:30 PM
zlei added a commit: rG59c399d38dd8: qlnxe: Remove a pointless copy back from the link-layer address.Thu, Feb 26, 2:34 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
qlnx/
qlnxe/
2 lines

Diff 171356

View Options

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...