qlnxe: Prevent potential concurrency between ioctls
ClosedPublic
Actions

Authored by zlei on Mon, Jan 26, 6:33 AM.

Details

Reviewers

Group Reviewers

Commits

rG0671ffe268f2: qlnxe: Prevent potential concurrency between ioctls
rG6e5b12acb66a: qlnxe: Prevent potential concurrency between ioctls
rG285b25c080fa: qlnxe: Prevent potential concurrency between ioctls
rG0df8a998a9fe: qlnxe: Prevent potential concurrency between ioctls

Summary

The driver-managed status flags should be lock protected to be touched.
Also this can serialize ioctls those check the IFF_DRV_RUNNING status.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Mon, Jan 26, 6:33 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 26, 6:33 AM

zlei requested review of this revision.Mon, Jan 26, 6:33 AM

zlei added a parent revision: D54885: qlnxe: Fix setting unicast MAC filter of rx path.Mon, Jan 26, 7:13 AM

zlei added a child revision: D54887: qlnxe: Avoid reinitializing the interface when it is already initialized.

kbowling accepted this revision.Fri, Feb 6, 6:17 AM

This revision is now accepted and ready to land.Fri, Feb 6, 6:17 AM

Closed by commit rG0df8a998a9fe: qlnxe: Prevent potential concurrency between ioctls (authored by zlei). · Explain WhyFri, Feb 6, 6:00 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG0df8a998a9fe: qlnxe: Prevent potential concurrency between ioctls.

zlei added a commit: rG285b25c080fa: qlnxe: Prevent potential concurrency between ioctls.Wed, Feb 11, 10:03 AM

zlei added a commit: rG6e5b12acb66a: qlnxe: Prevent potential concurrency between ioctls.Wed, Feb 11, 1:49 PM

cperciva added a commit: rG0671ffe268f2: qlnxe: Prevent potential concurrency between ioctls.Wed, Feb 11, 8:30 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlnx/

qlnxe/

qlnx_os.c

17 lines

Diff 171359

View Options

sys/dev/qlnx/qlnxe/qlnx_os.c

qlnxe: Prevent potential concurrency between ioctlsClosedPublicActions