Page MenuHomeFreeBSD
Differential D54888

qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
ClosedPublic
Actions

Authored by zlei on Mon, Jan 26, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 18, 3:22 PM
Unknown Object (File)
Sat, Feb 14, 6:03 PM
Unknown Object (File)
Fri, Feb 13, 10:29 PM
Unknown Object (File)
Tue, Feb 10, 9:44 PM
Unknown Object (File)
Tue, Feb 10, 6:27 PM
Unknown Object (File)
Mon, Feb 9, 12:21 AM
Unknown Object (File)
Sat, Feb 7, 6:44 PM
Unknown Object (File)
Sat, Feb 7, 2:59 AM
View All 16 Files
Subscribers
imp

Details

Reviewers
kbowling
Group Reviewers
network
Commits
rGbe256934d62e: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
rG20ffe22fcfe1: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
rG0f383f74b739: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
rG4012b63889e4: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
Summary

Since change [1] the init routine qlnx_init() works as intended, then
there is no need to handle SIOCSIFADDR ioctl by the driver.

Combined with D54887, this shall be a better fix for PR 287445.

[1] D54887 qlnxe: Avoid reinitializing the interface when it is already initialized

PR: 287445
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Mon, Jan 26, 6:40 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 26, 6:40 AM
zlei requested review of this revision.Mon, Jan 26, 6:40 AM
zlei mentioned this in D54889: qlnxev: Remove now unneeded include for opt_inet.h.Mon, Jan 26, 6:43 AM
zlei added a parent revision: D54887: qlnxe: Avoid reinitializing the interface when it is already initialized.Mon, Jan 26, 7:13 AM
zlei added a child revision: D54889: qlnxev: Remove now unneeded include for opt_inet.h.
kbowling accepted this revision.Fri, Feb 6, 6:27 AM

ack as long as the other review is ok

This revision is now accepted and ready to land.Fri, Feb 6, 6:27 AM
Closed by commit rG4012b63889e4: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl (authored by zlei). · Explain WhyFri, Feb 6, 6:00 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG4012b63889e4: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.
zlei added a commit: rG0f383f74b739: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.Wed, Feb 11, 10:03 AM
zlei added a commit: rG20ffe22fcfe1: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.Wed, Feb 11, 1:49 PM
cperciva added a commit: rGbe256934d62e: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.Wed, Feb 11, 8:30 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
qlnx/
qlnxe/
25 lines
modules/
qlnx/
qlnxe/
1 line

Diff 171361

View Options

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...
View Options

sys/modules/qlnx/qlnxe/Makefile

Loading...