Page MenuHomeFreeBSD
Differential D54888

qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
ClosedPublic
Actions

Authored by zlei on Jan 26 2026, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 28, 5:50 PM
Unknown Object (File)
Tue, Apr 28, 5:28 PM
Unknown Object (File)
Tue, Apr 28, 5:23 PM
Unknown Object (File)
Mon, Apr 27, 5:12 PM
Unknown Object (File)
Mon, Apr 27, 12:51 PM
Unknown Object (File)
Tue, Apr 21, 3:38 AM
Unknown Object (File)
Sun, Apr 12, 9:04 AM
Unknown Object (File)
Sat, Apr 11, 5:39 AM
View All 29 Files
Subscribers
imp

Details

Reviewers
kbowling
Group Reviewers
network
Commits
rG52609ccbf703: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
rGbe256934d62e: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
rG20ffe22fcfe1: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
rG0f383f74b739: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
rG4012b63889e4: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
Summary

Since change [1] the init routine qlnx_init() works as intended, then
there is no need to handle SIOCSIFADDR ioctl by the driver.

Combined with D54887, this shall be a better fix for PR 287445.

[1] D54887 qlnxe: Avoid reinitializing the interface when it is already initialized

PR: 287445
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Jan 26 2026, 6:40 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 26 2026, 6:40 AM
zlei requested review of this revision.Jan 26 2026, 6:40 AM
zlei mentioned this in D54889: qlnxev: Remove now unneeded include for opt_inet.h.Jan 26 2026, 6:43 AM
zlei added a parent revision: D54887: qlnxe: Avoid reinitializing the interface when it is already initialized.Jan 26 2026, 7:13 AM
zlei added a child revision: D54889: qlnxev: Remove now unneeded include for opt_inet.h.
kbowling accepted this revision.Feb 6 2026, 6:27 AM

ack as long as the other review is ok

This revision is now accepted and ready to land.Feb 6 2026, 6:27 AM
Closed by commit rG4012b63889e4: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl (authored by zlei). · Explain WhyFeb 6 2026, 6:00 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG4012b63889e4: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.
zlei added a commit: rG0f383f74b739: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.Feb 11 2026, 10:03 AM
zlei added a commit: rG20ffe22fcfe1: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.Feb 11 2026, 1:49 PM
cperciva added a commit: rGbe256934d62e: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.Feb 11 2026, 8:30 PM
zlei added a commit: rG52609ccbf703: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.Feb 24 2026, 10:46 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
qlnx/
qlnxe/
25 lines
modules/
qlnx/
qlnxe/
1 line

Diff 171361

View Options

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...
View Options

sys/modules/qlnx/qlnxe/Makefile

Loading...