Differential D54721

net: on interface detach purge all its routes before detaching protocols
ClosedPublic
Actions

Authored by glebius on Thu, Jan 15, 3:24 AM.

Tags

None

Referenced Files

	F144376407: D54721.id.diff
	Sun, Feb 8, 3:19 AM

	Unknown Object (File)
	Sat, Feb 7, 4:41 AM

	Unknown Object (File)
	Sat, Feb 7, 4:41 AM

	Unknown Object (File)
	Fri, Feb 6, 10:35 PM

	Unknown Object (File)
	Sat, Jan 31, 1:05 PM

	Unknown Object (File)
	Sat, Jan 31, 1:05 PM

	Unknown Object (File)
	Thu, Jan 29, 7:10 PM

	Unknown Object (File)
	Tue, Jan 27, 7:12 PM

View All 21 Files

Subscribers

Details

Reviewers

jhibbits
pouria

Group Reviewers

network
transport

Commits

rGf102a1834933: net: on interface detach purge all its routes before detaching protocols

Summary

Otherwise, a forwarding thread may use the interface being detached. This
is a regression from 0d469d23715d, which manifests itself as a reliably
reproducible panic in in6_selecthlim(). Note that there are old bug
reports about such a panic, and I believe this change will not fix them,
as their nature is not due to a screwed up detach sequence, but due to
lack of proper epoch(9) based synchronization between the detach and
forwarding.

Reported & tested by: jhibbits
PR: 292162
Fixes: 0d469d23715d690b863787ebfa51529e1f6a9092

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Thu, Jan 15, 3:24 AM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptThu, Jan 15, 3:24 AM

glebius requested review of this revision.Thu, Jan 15, 3:24 AM

Harbormaster completed remote builds in B69896: Diff 169749.Thu, Jan 15, 3:24 AM

glebius added a child revision: D54722: netinet6: embed struct nd_ifinfo into struct in6_ndireq.Thu, Jan 15, 3:24 AM

I will test it with openbgp and bird.
I suspect that removing routes before detaching the actual interface might cause unexpected behavior in them.

LGTM
I also tested interface creation and destruction to advertise/withdraw its routes with bird3 (ospf) and openbgpd8.

This revision is now accepted and ready to land.Fri, Jan 16, 3:01 PM

Closed by commit rGf102a1834933: net: on interface detach purge all its routes before detaching protocols (authored by glebius). · Explain WhySat, Jan 17, 12:45 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGf102a1834933: net: on interface detach purge all its routes before detaching protocols.

Revision Contents
Changeset List

Path

Size

sys/

net/

4 lines

Diff 169918

sys/net/if.c

Loading...