Page MenuHomeFreeBSD

netinet6: free in6_ifextra with epoch_call(9)
ClosedPublic

Authored by glebius on Thu, Jan 15, 3:25 AM.
Tags
None
Referenced Files
F144297313: D54728.id170305.diff
Sat, Feb 7, 5:19 PM
Unknown Object (File)
Mon, Jan 26, 1:24 PM
Unknown Object (File)
Sun, Jan 25, 1:16 PM
Unknown Object (File)
Fri, Jan 23, 10:35 PM
Unknown Object (File)
Thu, Jan 22, 8:20 PM
Unknown Object (File)
Tue, Jan 20, 8:08 AM
Unknown Object (File)
Fri, Jan 16, 6:56 PM
Unknown Object (File)
Thu, Jan 15, 5:18 PM

Details

Summary

This is expected to fix the old in6_selecthlim() panics. The nature of
the panic is that a packet sending thread will obtain the struct ifnet
pointer locklessly and then pick the if_inet6 pointer from it and
dereference it. While the struct ifnet is freed via epoch_call(9), the
struct in6_ifextra until this change was not. For the forwarded packets,
or locally originated non-TCP packets we were probably safe due to the old
if_dead trick. But locally originated TCP packets may dereference
in6_ifextra via direct call into in6_selecthlim() from the tcp_output(),
before ip6_output().

NB: hypothetically a similar problem also applies to IPv4's if_inet pointer,
but there are no known panics, yet.

PR: 279653

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable