Differential D54726

netinet6: embed struct scope6_id into struct in6_ifextra
ClosedPublic
Actions

Authored by glebius on Thu, Jan 15, 3:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 10, 7:33 AM

	Unknown Object (File)
	Sun, Feb 8, 5:04 PM

	Unknown Object (File)
	Sun, Feb 1, 6:55 AM

	Unknown Object (File)
	Sat, Jan 31, 6:24 PM

	Unknown Object (File)
	Fri, Jan 30, 12:41 AM

	Unknown Object (File)
	Mon, Jan 26, 1:24 PM

	Unknown Object (File)
	Sun, Jan 25, 2:17 PM

	Unknown Object (File)
	Sat, Jan 24, 3:04 AM

View All 19 Files

Subscribers

Details

Reviewers

jhibbits
tuexen

Group Reviewers

network
transport

Commits

rGaa3bbc06e5f0: netinet6: embed struct scope6_id into struct in6_ifextra

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Thu, Jan 15, 3:25 AM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptThu, Jan 15, 3:25 AM

glebius requested review of this revision.Thu, Jan 15, 3:25 AM

Harbormaster completed remote builds in B69901: Diff 169754.Thu, Jan 15, 3:25 AM

glebius added a parent revision: D54725: netinet6: store ND context directly in struct in6_ifextra.Thu, Jan 15, 3:25 AM

glebius added a child revision: D54727: netinet6: embed struct mld_ifsoftc into struct in6_ifextra.

Do we still need this? I think scope modification ability was not used/implemented since KAME import.

I have very little idea about that. I'm just working on making interfaces detach more safe and I want in6_ifextra to be a single piece of memory which would have delayed reclamation.

I'd be very happy if an IPv6 expert comes and axes of pieces of IPv6 that aren't needed at all. Some locking in scope6.c looks suspicious to me, so I doubt the code is actively used indeed.

tuexen accepted this revision.Fri, Jan 23, 9:02 PM

This revision is now accepted and ready to land.Fri, Jan 23, 9:02 PM

Closed by commit rGaa3bbc06e5f0: netinet6: embed struct scope6_id into struct in6_ifextra (authored by glebius). · Explain WhyFri, Jan 23, 10:37 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGaa3bbc06e5f0: netinet6: embed struct scope6_id into struct in6_ifextra.

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

2 lines

1 line

10 lines

19 lines

13 lines

Diff 170303

sys/netinet6/in6.c

Loading...

sys/netinet6/in6_ifattach.c

Loading...

sys/netinet6/in6_var.h

Loading...

sys/netinet6/scope6.c

Loading...

sys/netinet6/scope6_var.h

Loading...