Paths

Table of Contentst

Differential D54288

vtnet: expose features via sysctl tree
Needs ReviewPublic
Actions

Authored by tuexen on Thu, Dec 18, 4:16 PM.

Tags

None

Referenced Files

	F140009796: D54288.diff
	Thu, Dec 18, 11:50 PM

	F140004925: D54288.id.diff
	Thu, Dec 18, 10:12 PM

	F140004306: D54288.id168328.diff
	Thu, Dec 18, 9:59 PM

	F140003881: D54288.id168328.diff
	Thu, Dec 18, 9:51 PM

	F140003861: D54288.diff
	Thu, Dec 18, 9:50 PM

Subscribers

Details

Reviewers

timo.voelker_fh-muenster.de
glebius
markj

Summary

This depends on D54286 to express the bit position in a way, that more bits with positions 32 to 64 can be added.
Right now the 64-bit flags field needs to be casted to a 32-bit field, because clang warns if more than 32-bits are used. Once clang is fixed, this restriction will be removed and more bits will be added.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Thu, Dec 18, 4:16 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Dec 18, 4:16 PM

tuexen requested review of this revision.Thu, Dec 18, 4:16 PM

markj added inline comments.Thu, Dec 18, 9:05 PM

sys/dev/virtio/network/if_vtnet.c
4409	Can't sbuf_new_for_sysctl() be used here?

tuexen added inline comments.Thu, Dec 18, 11:33 PM

sys/dev/virtio/network/if_vtnet.c
4409	Don't know. Let me check...

Use sbuf_new_for_sysctl() as suggested by Mark.

tuexen marked an inline comment as done.Fri, Dec 19, 7:42 AM

tuexen added inline comments.

sys/dev/virtio/network/if_vtnet.c
4409	Done. Thanks for the suggestion, I did not know about `sbuf_new_for_sysctl()`.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

4 lines

sys/

dev/

virtio/

network/

18 lines

8 lines

Diff 168390

share/man/man4/vtnet.4

Loading...

sys/dev/virtio/network/if_vtnet.c

Loading...

sys/dev/virtio/network/virtio_net.h

Loading...