Page MenuHomeFreeBSD
Differential D54288

vtnet: expose features via sysctl tree
ClosedPublic
Actions

Authored by tuexen on Thu, Dec 18, 4:16 PM.
Tags
None
Referenced Files
F140144322: D54288.id168390.diff
Sat, Dec 20, 7:42 PM
Unknown Object (File)
Fri, Dec 19, 4:36 PM
Unknown Object (File)
Thu, Dec 18, 11:50 PM
Unknown Object (File)
Thu, Dec 18, 10:12 PM
Unknown Object (File)
Thu, Dec 18, 9:59 PM
Unknown Object (File)
Thu, Dec 18, 9:51 PM
Unknown Object (File)
Thu, Dec 18, 9:50 PM
Subscribers
imp
ziaee

Details

Reviewers
timo.voelker_fh-muenster.de
glebius
markj
Commits
rG634d9c0d111b: vtnet: expose features via sysctl tree
Summary

This depends on D54286 to express the bit position in a way, that more bits with positions 32 to 64 can be added.
Right now the 64-bit flags field needs to be casted to a 32-bit field, because clang warns if more than 32-bits are used. Once clang is fixed, this restriction will be removed and more bits will be added.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Thu, Dec 18, 4:16 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Dec 18, 4:16 PM
tuexen requested review of this revision.Thu, Dec 18, 4:16 PM
markj added inline comments.Thu, Dec 18, 9:05 PM
sys/dev/virtio/network/if_vtnet.c
4409

Can't sbuf_new_for_sysctl() be used here?

tuexen added inline comments.Thu, Dec 18, 11:33 PM
sys/dev/virtio/network/if_vtnet.c
4409

Don't know. Let me check...

tuexen updated this revision to Diff 168390.Fri, Dec 19, 7:41 AM

Use sbuf_new_for_sysctl() as suggested by Mark.

tuexen marked an inline comment as done.Fri, Dec 19, 7:42 AM
tuexen added inline comments.
sys/dev/virtio/network/if_vtnet.c
4409

Done. Thanks for the suggestion, I did not know about sbuf_new_for_sysctl().

markj accepted this revision.Fri, Dec 19, 2:14 PM
This revision is now accepted and ready to land.Fri, Dec 19, 2:14 PM
timo.voelker_fh-muenster.de accepted this revision.Fri, Dec 19, 3:43 PM
Closed by commit rG634d9c0d111b: vtnet: expose features via sysctl tree (authored by tuexen). · Explain WhyFri, Dec 19, 4:42 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rG634d9c0d111b: vtnet: expose features via sysctl tree.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
4 lines
sys/
dev/
virtio/
network/
18 lines
8 lines

Diff 168439

View Options

share/man/man4/vtnet.4

Loading...
View Options

sys/dev/virtio/network/if_vtnet.c

Loading...
View Options

sys/dev/virtio/network/virtio_net.h

Loading...