Page MenuHomeFreeBSD
Differential D52297

[net80211] add support for drivers to disable sending NULL data frames
ClosedPublic
Actions

Authored by adrian on Aug 31 2025, 3:07 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Sep 15, 5:01 PM
Unknown Object (File)
Tue, Sep 15, 11:18 AM
Unknown Object (File)
Sun, Sep 13, 11:45 PM
Unknown Object (File)
Sun, Sep 13, 3:59 PM
Unknown Object (File)
Sun, Sep 13, 2:57 PM
Unknown Object (File)
Sun, Sep 13, 4:49 AM
Unknown Object (File)
Sun, Sep 13, 12:37 AM
Unknown Object (File)
Sat, Sep 12, 2:57 PM
View All Files
Subscribers
bz
glebius
imp
melifaro

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rGb55f25d49be2: net80211: add support for drivers to disable sending NULL data frames
rG9bfb1405332c: net80211: add support for drivers to disable sending NULL data frames
Summary

net80211 has various places where null data / null qos data frames
are sent. However plenty of NICs shouldn't be sending them from
net80211 and it may even upset their 802.11n window / sequence number
tracking.

So add support here.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66701
Build 63584: arc lint + arc unit

Event Timeline

adrian created this revision.Aug 31 2025, 3:07 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptAug 31 2025, 3:07 AM
adrian requested review of this revision.Aug 31 2025, 3:07 AM
Harbormaster completed remote builds in B66701: Diff 161277.Aug 31 2025, 3:07 AM
adrian added a parent revision: D52142: [net80211] Quieten the logging from ieee80211_vht_get_vhtflags().Aug 31 2025, 3:07 AM
adrian added a child revision: D52298: [rtwn] don't send NULL data frames if we're compiled with firmware enabled.
adrian added a reviewer: wireless.Aug 31 2025, 3:16 AM
adrian added a project: wireless.
bz accepted this revision.Sep 1 2025, 1:17 AM
bz added a subscriber: bz.
bz added inline comments.
sys/net80211/ieee80211_output.c
1085

Comments end in a .

1086

style.9: if ((ic->ic_flags_ext & IEEE80211_FEXT_NO_NULLDATA) != 0)

This revision is now accepted and ready to land.Sep 1 2025, 1:17 AM
Closed by commit rG9bfb1405332c: net80211: add support for drivers to disable sending NULL data frames (authored by adrian). · Explain WhySep 9 2025, 1:53 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG9bfb1405332c: net80211: add support for drivers to disable sending NULL data frames.
bz added a commit: rGb55f25d49be2: net80211: add support for drivers to disable sending NULL data frames.Apr 22 2026, 9:09 PM

Revision Contents
Changeset List

PathSize
sys/
net80211/
6 lines
3 lines

Diff 161277

View Options

sys/net80211/ieee80211_output.c

Loading...
View Options

sys/net80211/ieee80211_var.h

Loading...