Details

Reviewers

des
kevans
zlei
markj
kp

Group Reviewers

network

Commits

rG4d281507f5f1: bridge: be consistent about PVID terminology

Summary

The PVID option is exposed to the user as 'untagged', but the API was
inconsistent on whether it's called 'untagged' or 'PVID'. Standardise
on calling it PVID everywhere in the code, since this is the 802.1Q
terminology.

Keep 'untagged' as the user-facing term since sysadmins are not network
admins and are often not familiar with the term PVID.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Jul 6 2025, 6:34 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptJul 6 2025, 6:34 PM

ivy requested review of this revision.Jul 6 2025, 6:34 PM

Harbormaster completed remote builds in B65238: Diff 158057.Jul 6 2025, 6:34 PM

ivy added a parent revision: D51181: bridge: exterr-ize.Jul 6 2025, 6:34 PM

ivy added a child revision: D51185: bridge.4: Improve VLAN documentation.Jul 6 2025, 8:24 PM

rebase on main and move out of the bridge stack so this can be landed quicker.

Harbormaster completed remote builds in B65803: Diff 159327.Jul 28 2025, 2:45 PM

ivy removed a parent revision: D51181: bridge: exterr-ize.Jul 28 2025, 2:45 PM

ivy removed a child revision: D51185: bridge.4: Improve VLAN documentation.

ivy added reviewers: zlei, markj.

ivy added a reviewer: kp.Jul 28 2025, 3:47 PM

des added inline comments.Jul 28 2025, 4:59 PM

sys/net/if_bridge.c
259–260	”port port vlan identifier”?

ivy added inline comments.Jul 28 2025, 5:01 PM

sys/net/if_bridge.c
259–260	on the one hand i appreciate we should avoid "PIN number" constructs, but i wonder if it isn't useful to be somewhat explicit here. perhaps "if PVID"?