Paths

Table of Contentst

Differential D47569

mv: Convert tests to ATF.
ClosedPublic
Actions

Authored by des on Nov 14 2024, 11:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 5, 7:22 AM

	Unknown Object (File)
	Sun, Nov 2, 3:24 PM

	Unknown Object (File)
	Thu, Oct 23, 4:37 AM

	Unknown Object (File)
	Thu, Oct 16, 4:08 AM

	Unknown Object (File)
	Tue, Oct 14, 1:29 PM

	Unknown Object (File)
	Tue, Oct 14, 1:24 PM

	Unknown Object (File)
	Tue, Oct 14, 1:24 PM

	Unknown Object (File)
	Tue, Oct 14, 1:24 PM

View All 100 Files

Subscribers

Details

Reviewers

asomers
markj

Group Reviewers

Klara
tests

Commits

rG2822a7953316: mv: Convert tests to ATF.

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Nov 14 2024, 11:31 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 14 2024, 11:31 AM

Harbormaster completed remote builds in B60555: Diff 146439.Nov 14 2024, 11:31 AM

des requested review of this revision.Nov 14 2024, 11:31 AM

des added a parent revision: D47568: mv: More style nits..

markj added a subscriber: markj.Nov 14 2024, 2:36 PM

markj added inline comments.

bin/mv/tests/mv_test.sh
9	Our usual shell style puts opening braces on their own lines, though admittedly a number of sh test files don't do this.
31	Should this be wrapped with `atf_check`?
42	Should this be wrapped with `atf_check`?

des added a reviewer: tests.Nov 14 2024, 4:18 PM

des added inline comments.

bin/mv/tests/mv_test.sh
9	I think we mostly don't in tests... maybe tests can weigh in
31	it should, thank you
42	it should, thank you

review feedback

Harbormaster completed remote builds in B60558: Diff 146448.Nov 14 2024, 4:35 PM

des marked 2 inline comments as done.Nov 14 2024, 4:35 PM

Shouldn't you delete cvt.pl? That looks like a one-time script to me.

In D47569#1085032, @asomers wrote:

Shouldn't you delete cvt.pl? That looks like a one-time script to me.

I never intended to add it, sorry

rm cvt.pl

Harbormaster completed remote builds in B60560: Diff 146454.Nov 14 2024, 6:14 PM

LGTM. If you're feeling ambitious you can add test cases for symlink destinations and the other command line options.

This revision is now accepted and ready to land.Nov 14 2024, 6:17 PM

descriptive names

This revision now requires review to proceed.Nov 14 2024, 7:43 PM

Harbormaster completed remote builds in B60571: Diff 146468.Nov 14 2024, 7:43 PM

des added a child revision: D47582: mv: Add test cases for command-line options..Nov 14 2024, 8:13 PM

markj accepted this revision as: markj.Nov 16 2024, 4:51 PM

This revision is now accepted and ready to land.Nov 16 2024, 4:51 PM

asomers accepted this revision.Nov 16 2024, 6:50 PM

Closed by commit rG2822a7953316: mv: Convert tests to ATF. (authored by des). · Explain WhyNov 19 2024, 8:54 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG2822a7953316: mv: Convert tests to ATF..

Revision Contents
Changeset List

Path

Size

ObsoleteFiles.inc

3 lines

bin/

mv/

tests/

2 lines

391 lines

Diff 146720

ObsoleteFiles.inc

Loading...

bin/mv/tests/Makefile

Loading...

bin/mv/tests/legacy_test.sh

Loading...

bin/mv/tests/mv_test.sh

Loading...