Sponsored by: Klara, Inc.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Fine with me aside from the one comment.
| bin/mv/mv.c | ||
|---|---|---|
| 221 | style(9) explicitly permits this, and I don't see a good reason to move the declarations. | |
| bin/mv/mv.c | ||
|---|---|---|
| 221 | It stuck out as being the only local definition in a file that otherwise declares all its variables at the top of each function. It shouldn't make any difference to the generated code. | |
| bin/mv/mv.c | ||
|---|---|---|
| 221 | I understand that it won't change any code, I just think it doesn't make sense to move variables to a larger scope for no reason. Anyway, I don't object to either version. | |