Differential D46610

flua: move modules source into the main source directory
ClosedPublic
Actions

Authored by bapt on Sep 9 2024, 3:26 PM.

Tags

None

Referenced Files

	F151544073: D46610.id.diff
	Thu, Apr 9, 2:47 AM

	Unknown Object (File)
	Tue, Apr 7, 1:20 PM

	Unknown Object (File)
	Sat, Apr 4, 9:40 AM

	Unknown Object (File)
	Sat, Apr 4, 1:19 AM

	Unknown Object (File)
	Thu, Apr 2, 5:21 PM

	Unknown Object (File)
	Tue, Mar 24, 1:54 PM

	Unknown Object (File)
	Fri, Mar 20, 6:33 AM

	Unknown Object (File)
	Fri, Mar 20, 5:41 AM

Subscribers

Details

Reviewers

imp
markj
kevans
manu

Commits

rGcf48057f3ea9: flua: move modules source into the main source directory
rG7899f917b1c0: flua: move modules source into the main source directory

Summary

Follow the path of what is done with bsnmp, build the modules along
with the main binary, this allows to build the modules at a moment
where all needed libraries are already built and available in the
linker path instead of having to declare all the libraries which a
flua module will be linked to in _prebuild_libs.

Discused with: markj

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Sep 9 2024, 3:26 PM

Herald added a subscriber: emaste. · View Herald TranscriptSep 9 2024, 3:26 PM

bapt requested review of this revision.Sep 9 2024, 3:26 PM

Harbormaster completed remote builds in B59405: Diff 143142.Sep 9 2024, 3:26 PM

bapt added reviewers: markj, kevans.Sep 10 2024, 4:09 PM

markj added inline comments.Sep 11 2024, 3:49 PM

libexec/flua/Makefile
3	Don't you need to add the other libraries here?

jrtc27 added a subscriber: jrtc27.Sep 11 2024, 3:50 PM

jrtc27 added inline comments.

libexec/flua/Makefile
3	Missing the others?

add forgotten libraries

Harbormaster completed remote builds in B59446: Diff 143257.Sep 11 2024, 3:54 PM

bapt marked 2 inline comments as done.Sep 11 2024, 3:54 PM

Fix libstand after moving lualibs

Herald added a reviewer: manu. · View Herald TranscriptSep 11 2024, 8:19 PM

Herald added a subscriber: dab. · View Herald Transcript

Harbormaster completed remote builds in B59447: Diff 143258.Sep 11 2024, 8:19 PM

imp accepted this revision.Sep 12 2024, 2:42 AM

This revision is now accepted and ready to land.Sep 12 2024, 2:42 AM

kevans accepted this revision.Sep 12 2024, 3:10 AM

Closed by commit rG7899f917b1c0: flua: move modules source into the main source directory (authored by bapt). · Explain WhySep 12 2024, 7:08 AM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG7899f917b1c0: flua: move modules source into the main source directory.

bapt added a commit: rGcf48057f3ea9: flua: move modules source into the main source directory.Jul 8 2025, 2:33 PM

Herald added a subscriber: ziaee. · View Herald TranscriptJul 8 2025, 2:33 PM

Revision Contents
Changeset List

Path

Size

4 lines

lib/

5 lines

flua/

libfreebsd/

sys/

linker/

freebsd.sys.linker.3lua

libhash/

libjail/

libucl/

libexec/

flua/

5 lines

5 lines

libfreebsd/

1 line

sys/

1 line

linker/

7 lines

libhash/

9 lines

	libexec/	flua/
	lib/	flua/

libfreebsd/

sys/

linker/

freebsd.sys.linker.3lua

libhash/

libjail/

5 lines

libucl/

3 lines

stand/

2 lines

Diff 143265

Makefile.inc1

Loading...

lib/Makefile

Loading...

lib/flua/Makefile

Loading...

lib/flua/libfreebsd/Makefile

Loading...

lib/flua/libfreebsd/sys/Makefile

Loading...

lib/flua/libfreebsd/sys/linker/Makefile

Loading...

lib/flua/libfreebsd/sys/linker/freebsd.sys.linker.3lua

Loading...

lib/flua/libfreebsd/sys/linker/linker.c

Loading...

lib/flua/libhash/Makefile

Loading...

lib/flua/libhash/hash.3lua

Loading...

lib/flua/libhash/lhash.h

Loading...

lib/flua/libhash/lhash.c

Loading...

lib/flua/libjail/Makefile

Loading...

lib/flua/libjail/jail.3lua

Loading...

lib/flua/libjail/lua_jail.c

Loading...

lib/flua/libucl/Makefile

Loading...

libexec/flua/Makefile

Loading...

libexec/flua/Makefile.inc

Loading...

libexec/flua/libfreebsd/Makefile

Loading...

libexec/flua/libfreebsd/Makefile.inc

Loading...

libexec/flua/libfreebsd/sys/Makefile

Loading...

libexec/flua/libfreebsd/sys/Makefile.inc

Loading...

libexec/flua/libfreebsd/sys/linker/Makefile

Loading...

libexec/flua/libfreebsd/sys/linker/freebsd.sys.linker.3lua

Loading...

libexec/flua/libfreebsd/sys/linker/linker.c

Loading...

libexec/flua/libhash/Makefile

Loading...

libexec/flua/libhash/hash.3lua

Loading...

libexec/flua/libhash/lhash.h

Loading...

libexec/flua/libhash/lhash.c

Loading...

libexec/flua/libjail/Makefile

Loading...

libexec/flua/libjail/jail.3lua

Loading...

libexec/flua/libjail/lua_jail.c

Loading...

libexec/flua/libucl/Makefile

Loading...

stand/defs.mk

Loading...