Page MenuHomeFreeBSD

man4: Add a manual page for kvmclock
ClosedPublic

Authored by markj on Feb 1 2023, 5:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 5:05 AM
Unknown Object (File)
Feb 7 2024, 4:27 PM
Unknown Object (File)
Dec 3 2023, 4:05 PM
Unknown Object (File)
Dec 2 2023, 7:03 AM
Unknown Object (File)
Nov 26 2023, 10:51 AM
Unknown Object (File)
Nov 25 2023, 10:47 PM
Unknown Object (File)
Nov 25 2023, 9:52 AM
Unknown Object (File)
Nov 22 2023, 8:27 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Feb 1 2023, 5:18 PM
share/man/man4/kvmclock.4
4

Can we get a SPDX-License-Identifier line too please?

25

Is this being merged to 12?

35

there's only one line...

79

prior to when?

markj marked 3 inline comments as done.Feb 1 2023, 5:31 PM
markj added inline comments.
share/man/man4/kvmclock.4
25

I probably won't, I'll just remove this tag.

79

Prior to the patches in D38341-2, assuming they get committed. :)

I'm not really sure how to express that here. Maybe just say, anything using a libc.so older than 14.0-RELEASE's or anything statically linked before 14.0 came out.

markj marked an inline comment as done.
  • Handle review feedback.
imp added inline comments.
share/man/man4/kvmclock.4
79

Yea prior to 14.0... unless this get merged back to 13.2. Release granularity likely is fine

This revision is now accepted and ready to land.Feb 1 2023, 5:41 PM

Since the driver is in 13.1, perhaps MFC?

share/man/man4/kvmclock.4
2–23

Per https://docs.freebsd.org/en/articles/license-guide/#pref-license, this should have a SDPX license identifier. Whether to keep the license text as well is (I think) up to you.

25

Not needed anymore for new files.

74

US spelling

85

Clarify "systems"? kernel?

markj marked 5 inline comments as done.

Review feedback.

This revision now requires review to proceed.Feb 1 2023, 7:15 PM
share/man/man4/kvmclock.4
53

So these are no longer system calls. Might be call them functions?

79

Why libc.so and not libc.so.7? libc.so is not a shared object at all.

markj marked 2 inline comments as done.
  • /usr/lib/libc.so -> /lib/libc.so.7
  • Refer to clock_gettime() as a function rather than a system call since that's more accurate in this context.
This revision is now accepted and ready to land.Feb 1 2023, 9:01 PM

Device name correction (if I'm right) can be fixed on commit.

share/man/man4/kvmclock.4
38

kvmclock, I think?

markj added inline comments.
share/man/man4/kvmclock.4
38

kvm_clock is correct, unfortunately. The path is sys/dev/kvm_clock. But internally the driver is called kvmclock.

This revision was automatically updated to reflect the committed changes.
markj marked an inline comment as done.