Update comments referencing create_thread()
ClosedPublic
Actions

Authored by mhorne on Jan 24 2023, 9:51 PM.

Details

Reviewers

jhb
kib
markj

Commits

rG27cd9722efb1: Update comments referencing create_thread()
rGa7a452fedc42: Update comments referencing create_thread()

Summary

The equivalent function is now named thread_create(). Mention
kthread_add(9) where it is also relevant.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Jan 24 2023, 9:51 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 24 2023, 9:51 PM

mhorne requested review of this revision.Jan 24 2023, 9:51 PM

mhorne added a child revision: D38181: Boolify should_yield().

Harbormaster completed remote builds in B49209: Diff 115557.Jan 24 2023, 9:51 PM

markj accepted this revision.Jan 24 2023, 9:58 PM

This revision is now accepted and ready to land.Jan 24 2023, 9:58 PM

kib accepted this revision.Jan 25 2023, 1:26 AM

kib added inline comments.

sys/sys/proc.h
261	I find it somewhat unusual to reference functions as man pages (`kthread_add(9)`), esp, mixing two styles in the same sentence.

Closed by commit rGa7a452fedc42: Update comments referencing create_thread() (authored by mhorne). · Explain WhyFeb 9 2023, 4:02 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGa7a452fedc42: Update comments referencing create_thread().

mhorne added a commit: rG27cd9722efb1: Update comments referencing create_thread().Feb 15 2023, 4:43 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_kthread.c

2 lines

sys/

proc.h

6 lines

Diff 116848

View Options

sys/kern/kern_kthread.c