Page MenuHomeFreeBSD

ifnet/API: Change if_set*bit accessors to clear first
ClosedPublic

Authored by jhibbits on Jan 9 2023, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 5:56 PM
Unknown Object (File)
Sun, Aug 9, 9:15 PM
Unknown Object (File)
Sat, Aug 8, 9:57 PM
Unknown Object (File)
Fri, Aug 7, 1:45 AM
Unknown Object (File)
Thu, Aug 6, 12:44 AM
Unknown Object (File)
Sat, Aug 1, 1:50 AM
Unknown Object (File)
Fri, Jul 31, 4:52 AM
Unknown Object (File)
Thu, Jul 30, 9:31 AM
Subscribers

Details

Summary

A common pattern has been to:

if (foo)

		caps = IFCAP_FOO;

ifp->if_capenable &= ~IFCAP_FOO;
ifp->if_capenable |= caps;

which in the new order of things would be:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, 0, IFCAP_FOO);
if_setcapenablebits(ifp, caps, 0);

This change streamlines this into:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, caps, IFCAP_FOO);

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable