Page MenuHomeFreeBSD

ifnet/API: Change if_set*bit accessors to clear first
ClosedPublic

Authored by jhibbits on Jan 9 2023, 7:22 PM.
Tags
None
Referenced Files
F172422329: D37993.diff
Fri, Sep 18, 8:56 AM
Unknown Object (File)
Thu, Sep 17, 4:47 AM
Unknown Object (File)
Sat, Sep 12, 2:38 AM
Unknown Object (File)
Sun, Sep 6, 3:04 PM
Unknown Object (File)
Sun, Sep 6, 2:31 PM
Unknown Object (File)
Sun, Sep 6, 1:35 PM
Unknown Object (File)
Sun, Sep 6, 12:36 PM
Unknown Object (File)
Sun, Sep 6, 2:30 AM
Subscribers

Details

Summary

A common pattern has been to:

if (foo)

		caps = IFCAP_FOO;

ifp->if_capenable &= ~IFCAP_FOO;
ifp->if_capenable |= caps;

which in the new order of things would be:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, 0, IFCAP_FOO);
if_setcapenablebits(ifp, caps, 0);

This change streamlines this into:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, caps, IFCAP_FOO);

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable