Page MenuHomeFreeBSD

ifnet/API: Change if_set*bit accessors to clear first
ClosedPublic

Authored by jhibbits on Jan 9 2023, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 8:21 AM
Unknown Object (File)
Dec 13 2023, 10:45 PM
Unknown Object (File)
Nov 19 2023, 6:37 PM
Unknown Object (File)
Jul 2 2023, 11:31 AM
Unknown Object (File)
Jul 2 2023, 11:31 AM
Unknown Object (File)
Jul 2 2023, 11:29 AM
Unknown Object (File)
Jul 2 2023, 11:06 AM
Unknown Object (File)
Apr 3 2023, 12:09 AM
Subscribers

Details

Summary

A common pattern has been to:

if (foo)

		caps = IFCAP_FOO;

ifp->if_capenable &= ~IFCAP_FOO;
ifp->if_capenable |= caps;

which in the new order of things would be:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, 0, IFCAP_FOO);
if_setcapenablebits(ifp, caps, 0);

This change streamlines this into:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, caps, IFCAP_FOO);

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable