Page MenuHomeFreeBSD

ifnet/API: Change if_set*bit accessors to clear first
ClosedPublic

Authored by jhibbits on Jan 9 2023, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 25, 5:32 AM
Unknown Object (File)
Sun, Nov 23, 4:13 PM
Unknown Object (File)
Sat, Nov 15, 11:22 PM
Unknown Object (File)
Sun, Nov 9, 10:09 PM
Unknown Object (File)
Sun, Nov 2, 10:50 AM
Unknown Object (File)
Thu, Oct 30, 10:18 PM
Unknown Object (File)
Thu, Oct 30, 6:39 PM
Unknown Object (File)
Wed, Oct 29, 1:04 PM
Subscribers

Details

Summary

A common pattern has been to:

if (foo)

		caps = IFCAP_FOO;

ifp->if_capenable &= ~IFCAP_FOO;
ifp->if_capenable |= caps;

which in the new order of things would be:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, 0, IFCAP_FOO);
if_setcapenablebits(ifp, caps, 0);

This change streamlines this into:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, caps, IFCAP_FOO);

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable