Page MenuHomeFreeBSD

ifnet/API: Change if_set*bit accessors to clear first
ClosedPublic

Authored by jhibbits on Jan 9 2023, 7:22 PM.
Tags
None
Referenced Files
F153401240: D37993.id114879.diff
Mon, Apr 20, 11:04 PM
Unknown Object (File)
Mon, Apr 20, 2:51 AM
Unknown Object (File)
Sun, Apr 19, 9:26 PM
Unknown Object (File)
Sun, Apr 19, 3:07 PM
Unknown Object (File)
Mon, Mar 23, 7:37 AM
Unknown Object (File)
Mar 22 2026, 2:51 AM
Unknown Object (File)
Mar 21 2026, 11:57 PM
Unknown Object (File)
Mar 16 2026, 10:15 AM
Subscribers

Details

Summary

A common pattern has been to:

if (foo)

		caps = IFCAP_FOO;

ifp->if_capenable &= ~IFCAP_FOO;
ifp->if_capenable |= caps;

which in the new order of things would be:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, 0, IFCAP_FOO);
if_setcapenablebits(ifp, caps, 0);

This change streamlines this into:

if (foo)

		caps = IF_FOO;

if_setcapenablebits(ifp, caps, IFCAP_FOO);

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable