Paths

Table of Contentst

Differential D35409

ifconfig.8: Update to reflect the removal of FDDI and Token Ring media support
ClosedPublic
Actions

Authored by zlei on Jun 6 2022, 8:12 AM.

Tags

None

Referenced Files

	F153698897: D35409.id.diff
	Thu, Apr 23, 12:57 AM

	F153689953: D35409.id106957.diff
	Wed, Apr 22, 10:59 PM

	Unknown Object (File)
	Tue, Apr 21, 4:28 PM

	Unknown Object (File)
	Mon, Apr 20, 1:08 PM

	Unknown Object (File)
	Sat, Apr 18, 10:52 PM

	Unknown Object (File)
	Wed, Apr 8, 11:52 PM

	Unknown Object (File)
	Tue, Apr 7, 2:49 PM

	Unknown Object (File)
	Mon, Apr 6, 8:06 PM

Subscribers

Details

Reviewers

brooks
pauamma_gundo.com

Group Reviewers

Commits

rGf636f38bd756: ifconfig.8: reflect removal of FDDI and Token Ring
rG030f3ee99583: ifconfig.8: reflect removal of FDDI and Token Ring

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jun 6 2022, 8:12 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 6 2022, 8:12 AM

zlei requested review of this revision.Jun 6 2022, 8:12 AM

zlei added a child revision: D35384: ifconfig.8: Prefer consistent terminologies.

pauamma_gundo.com added inline comments.Jun 9 2022, 7:04 PM

sbin/ifconfig/ifconfig.8
410	Are Wifi MAC addresses considered the same as Ethernet addresses? (If not, or maybe even if they're the same, for less ambiguity, I'd mention them here. ) A quick look says there are 3 per frame, not 2, but they're the same length and `ifconfig wlan0` calls it "ether", so I don't know.

pauamma_gundo.com mentioned this in D35384: ifconfig.8: Prefer consistent terminologies.Jun 9 2022, 7:09 PM

zlei added inline comments.Jun 10 2022, 4:47 AM

sbin/ifconfig/ifconfig.8
410	As for `Ethernet`, I think it covers wired Ethernet and wireless Ethernet (also known as Wi-Fi or 802.11 network). So it won't cause ambiguities. I'm not expert in wireless Ethernet. Glad to hear more voices about that.

pauamma_gundo.com accepted this revision.Jun 14 2022, 11:17 PM

pauamma_gundo.com added inline comments.

sbin/ifconfig/ifconfig.8
410	WFM. Not going to delay approval longer since no one objected in 4 days.

This revision is now accepted and ready to land.Jun 14 2022, 11:17 PM

Hi @brooks , I do not have direct access to src repository, may you please commit this?

Closed by commit rG030f3ee99583: ifconfig.8: reflect removal of FDDI and Token Ring (authored by zlei, committed by brooks). · Explain WhyJun 15 2022, 5:53 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG030f3ee99583: ifconfig.8: reflect removal of FDDI and Token Ring.

@brooks Thanks !

brooks added a commit: rGf636f38bd756: ifconfig.8: reflect removal of FDDI and Token Ring.Jun 20 2022, 10:07 PM

zlei mentioned this in D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.Jun 29 2022, 10:41 AM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

2 lines

Diff 106957

sbin/ifconfig/ifconfig.8

Loading...