Differential D35384

ifconfig.8: Prefer consistent terminologies
ClosedPublic
Actions

Authored by zlei.huang_gmail.com on Jun 2 2022, 9:48 AM.

Tags

None

Subscribers

Details

Reviewers

0mp
pauamma
email_luiz.eng.br

Group Reviewers

Commits

rG52832592bd7d: ifconfig.8: Prefer consistent terminologies
rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zlei.huang_gmail.com created this revision.Jun 2 2022, 9:48 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 2 2022, 9:48 AM

zlei.huang_gmail.com requested review of this revision.Jun 2 2022, 9:48 AM

zlei.huang_gmail.com added a child revision: D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

email_luiz.eng.br accepted this revision.Jun 2 2022, 10:11 AM

This revision is now accepted and ready to land.Jun 2 2022, 10:11 AM

zlei.huang_gmail.com added a reviewer: manpages.Jun 2 2022, 10:42 AM

pauamma requested changes to this revision.Jun 2 2022, 11:11 PM

pauamma added inline comments.

sbin/ifconfig/ifconfig.8
422	Given FreeBSD hasn't supported Token Ring LANs for... IIRC over a decade? I'd remove that while here.

This revision now requires changes to proceed.Jun 2 2022, 11:11 PM

zlei.huang_gmail.com updated this revision to Diff 106650.Jun 6 2022, 2:19 AM

@pauamma_gundo.com And what about the support status of FDDI ? It has been removed via D15017 and D15170 .

zlei.huang_gmail.com added a parent revision: D35409: ifconfig.8: Update to reflect the removal of FDDI and Token Ring media support.Jun 6 2022, 8:12 AM

zlei.huang_gmail.com retitled this revision from ifconfig.8: Prefer consistent terminology to ifconfig.8: Prefer consistent terminologies.

In D35384#802893, @zlei.huang_gmail.com wrote:

@pauamma_gundo.com And what about the support status of FDDI ? It has been removed via D15017 and D15170 .

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

In D35384#803753, @pauamma_gundo.com wrote:

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

Or are you planning to do that in D35409 instead?

In D35384#803849, @pauamma_gundo.com wrote:

In D35384#803753, @pauamma_gundo.com wrote:

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

Or are you planning to do that in D35409 instead?

Yes, I think they are left by D15017 and D15170, so fix it separately.

zlei.huang_gmail.com updated this revision to Diff 106977.Jun 16 2022, 2:20 AM

Ping @pauamma_gundo.com since the parent D35409 has been merged.

pauamma accepted this revision.Jun 17 2022, 1:54 AM

This revision is now accepted and ready to land.Jun 17 2022, 1:54 AM

Hi @0mp , do you have any objections ?

Ping @0mp

Closed by commit rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies (authored by zlei.huang_gmail.com, committed by 0mp). · Explain WhyJun 29 2022, 6:59 AM

This revision was automatically updated to reflect the committed changes.

0mp added a commit: rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies.

@0mp Thanks!

zlei.huang_gmail.com mentioned this in D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.Jun 29 2022, 10:41 AM

0mp added a commit: rG52832592bd7d: ifconfig.8: Prefer consistent terminologies.Thu, Jul 21, 11:57 PM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

8 lines

Diff 107519

sbin/ifconfig/ifconfig.8

Loading...