Page MenuHomeFreeBSD

make buildworld with time logging for each stage
ClosedPublic

Authored by wosch on Jul 12 2021, 6:02 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wosch requested review of this revision.Jul 12 2021, 6:02 PM
wosch retitled this revision from make buildworld with time logging to make buildworld with time logging for each stage.

Would you be so kind as to show (snippets from) sample output with this change? I think having this sort of data available will be quite useful, just curious how it will look in practice.

Sounds like something that should be put in a variabe TIME_ENV ?= time env that way anyone who doesn't want it, or suspects it is causing trouble can TIME_ENV= to disable

new variable TIME_ENV for "time env" commands

In D31154#702761, @sjg wrote:

Sounds like something that should be put in a variabe TIME_ENV ?= time env that way anyone who doesn't want it, or suspects it is causing trouble can TIME_ENV= to disable

Good point, I will update the patch.

Any comment or objections to the patch? Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2021, 9:14 AM
This revision was automatically updated to reflect the committed changes.

Why is this on by default rather than guarded by a -DWITH_TIME_MAKE? It's clutter that's printed with no context and should not be of relevance to the vast majority of people building FreeBSD.

Also, isn't the output going to vary based on what shell you're using, and possibly what OS if it's not a builtin in your shell? That's not a particularly great experience.