Differential D29838

Add more checking for unmapped mbufs
ClosedPublic
Actions

Authored by markj on Apr 19 2021, 3:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 9, 1:24 PM

	Unknown Object (File)
	Sun, Nov 30, 4:56 AM

	Unknown Object (File)
	Mon, Nov 17, 9:00 PM

	Unknown Object (File)
	Nov 6 2025, 2:47 AM

	Unknown Object (File)
	Nov 6 2025, 12:54 AM

	Unknown Object (File)
	Nov 6 2025, 12:54 AM

	Unknown Object (File)
	Nov 5 2025, 10:59 PM

	Unknown Object (File)
	Nov 4 2025, 1:01 PM

Subscribers

Details

Reviewers

ae
tuexen
jhb
gallatin

Commits

rG2b826286c3b9: Add required checks for unmapped mbufs in ipdivert and ipfw
rG652908599b6f: Add required checks for unmapped mbufs in ipdivert and ipfw

Summary

ipdivert and ipfw nat64 need to handle unmapped mbufs
Add a M_ASSERTMAPPED() assertion which verifies that all mbufs in a chain are mapped.
Use M_ASSERTMAPPED() in ipfw nat. m_megapullup() returns mapped mbuf clusters.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 19 2021, 3:40 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptApr 19 2021, 3:40 PM

markj requested review of this revision.Apr 19 2021, 3:40 PM

Harbormaster completed remote builds in B38688: Diff 87717.Apr 19 2021, 3:40 PM

markj added reviewers: ae, tuexen, jhb, gallatin.Apr 19 2021, 3:40 PM

gallatin accepted this revision.Apr 19 2021, 4:15 PM

This revision is now accepted and ready to land.Apr 19 2021, 4:15 PM

ae accepted this revision.Apr 20 2021, 4:48 AM

Closed by commit rG652908599b6f: Add required checks for unmapped mbufs in ipdivert and ipfw (authored by markj). · Explain WhyApr 21 2021, 8:00 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG652908599b6f: Add required checks for unmapped mbufs in ipdivert and ipfw.

markj added a commit: rG2b826286c3b9: Add required checks for unmapped mbufs in ipdivert and ipfw.Apr 28 2021, 2:10 PM

sobomax mentioned this in D43776: Disambiguate KASSERTs in the m_apply() mbuf checking code and provide more context.Feb 7 2024, 1:40 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

6 lines

netpfil/

ipfw/

1 line

nat64/

nat64_translate.c

10 lines

sys/

11 lines

Diff 87893

sys/netinet/ip_divert.c

Loading...

sys/netpfil/ipfw/ip_fw_nat.c

Loading...

sys/netpfil/ipfw/nat64/nat64_translate.c

Loading...

sys/sys/mbuf.h

Loading...