Page MenuHomeFreeBSD

Contributor Reviews (base)Project
ActivePublic

Recent Activity

Today

james.wright_jigsawdezign.com updated the diff for D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).

Fixed file path in diff for Phabricator

Sat, Dec 15, 3:37 PM · Contributor Reviews (base)

Tue, Dec 11

dab closed D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Tue, Dec 11, 4:36 PM · Contributor Reviews (base)
dab closed D18395: Add uk.macbook.kbd keymap (vt).
Tue, Dec 11, 2:14 AM · Contributor Reviews (base)
dab updated the summary of D18395: Add uk.macbook.kbd keymap (vt).
Tue, Dec 11, 12:59 AM · Contributor Reviews (base)

Sat, Dec 8

james.wright_jigsawdezign.com updated the summary of D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Sat, Dec 8, 11:30 AM · Contributor Reviews (base)
james.wright_jigsawdezign.com updated the summary of D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Sat, Dec 8, 11:29 AM · Contributor Reviews (base)
james.wright_jigsawdezign.com updated the summary of D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Sat, Dec 8, 5:01 AM · Contributor Reviews (base)
james.wright_jigsawdezign.com created D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Sat, Dec 8, 5:00 AM · Contributor Reviews (base)

Sat, Dec 1

dab updated the diff for D18395: Add uk.macbook.kbd keymap (vt).

After commandeering the revision, updating it to make sure my diff is the same as the previously submitted diff.

Sat, Dec 1, 6:56 PM · Contributor Reviews (base)
dab added reviewers for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2: rpaulo, adrian.

Adding @adrian and @rpaulo as reviewers, as they have been in this code before and might have input.

Sat, Dec 1, 6:50 PM · Contributor Reviews (base)
dab updated the diff for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

After commandeering the revision, updating it to make sure my diff is
the same as the previously submitted diff.

Sat, Dec 1, 6:47 PM · Contributor Reviews (base)
dab commandeered D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

I'll take over this diff and get it committed to -CURRENT in the next few days.

Sat, Dec 1, 6:27 PM · Contributor Reviews (base)
james.wright_jigsawdezign.com updated the test plan for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Sat, Dec 1, 3:04 PM · Contributor Reviews (base)
james.wright_jigsawdezign.com updated the summary of D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Sat, Dec 1, 3:04 PM · Contributor Reviews (base)
james.wright_jigsawdezign.com added a comment to D18395: Add uk.macbook.kbd keymap (vt).
In D18395#391434, @dab wrote:

Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?

Sat, Dec 1, 3:39 AM · Contributor Reviews (base)
dab commandeered D18395: Add uk.macbook.kbd keymap (vt).

Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?

Sat, Dec 1, 2:41 AM · Contributor Reviews (base)
james.wright_jigsawdezign.com added a comment to D18395: Add uk.macbook.kbd keymap (vt).
In D18395#391412, @dab wrote:

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Sat, Dec 1, 12:07 AM · Contributor Reviews (base)

Fri, Nov 30

dab added a comment to D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Fri, Nov 30, 11:32 PM · Contributor Reviews (base)
dab added a comment to D18395: Add uk.macbook.kbd keymap (vt).

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Fri, Nov 30, 11:32 PM · Contributor Reviews (base)
emaste accepted D18395: Add uk.macbook.kbd keymap (vt).
Fri, Nov 30, 7:38 PM · Contributor Reviews (base)
markj added a reviewer for D18395: Add uk.macbook.kbd keymap (vt): emaste.
Fri, Nov 30, 6:22 PM · Contributor Reviews (base)
james.wright_jigsawdezign.com updated the summary of D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Fri, Nov 30, 5:33 PM · Contributor Reviews (base)
james.wright_jigsawdezign.com created D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Fri, Nov 30, 5:33 PM · Contributor Reviews (base)
james.wright_jigsawdezign.com created D18395: Add uk.macbook.kbd keymap (vt).
Fri, Nov 30, 5:25 PM · Contributor Reviews (base)

Sun, Nov 25

jeymon_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Many thanks for these files and patches.
Now my Asus Vivobook S15 touchpad is working running FreeBSD 12.RC1, kernel source revision 340904.

Sun, Nov 25, 8:09 PM · Contributor Reviews (base)

Nov 1 2018

johalun0_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Thanks for doing this! Works great on my Dell 7490.
Suspend/resume not tested. Please also add EVDEV to this driver so we can get things like horizontal scrolling :)

Nov 1 2018, 11:10 AM · Contributor Reviews (base)

Oct 21 2018

daniel.piecebypiece_yahoo.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Awesome Mark.
It works on my Huawei Matebook X Pro. Sorry for comming back so late.
I had 10 minutes to test and here are my initial findings.

Oct 21 2018, 10:52 AM · Contributor Reviews (base)

Oct 19 2018

lizhichao877_163.com added a comment to D16698: First draft HID over I2C support (Mouse only).

@marc.priggemeyer_gmail.com
sorry for bothering you guys
I have managed to kldload acpi_iicbus.ko
but my mosuepad doesn't work
here is my latest FreeBSD dmesg output:
ig4iic_pci0: <Intel Sunrise Point-LP I2C Controller-0> mem 0xd2336000-0xd2336fff at device 21.0 on pci0
ig4iic_pci0: Using MSI
iicbus0: <Philips I2C bus> on ig4iic_pci0
acpi_iichid0: <HID over I2C (ACPI)> irq 51 on acpi0
acpi_iichid0: descriptor register address is 1
acpi_iichid0: - irq: 51
acpi_iichid0: parent device is "\134_SB_.PCI0.I2C0"
iichid0: <HID over I2C> at addr 0x15 on iicbus0
iichid0: ADDR 0x15 REG 0x1
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
iichid0: 3 buttons and [XY] coordinates ID=1
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
iichid0: 3 buttons and [XY] coordinates ID=1
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
acpi_iichid0: added iichid0 ADDR 0x15 REG 0x1 to iicbus0
acpi_iichid0: allocated irq at 0xfffff801088b6780 and rid 0
acpi_iichid0: successfully setup interrupt

Oct 19 2018, 10:14 AM · Contributor Reviews (base)

Oct 18 2018

lizhichao877_163.com added a comment to D16698: First draft HID over I2C support (Mouse only).

@marc.priggemeyer_gmail.com hello sir can you be so kind to help me out, when I try to kldload acpi_iichid.ko it says 'parent is not attached', what should I kldload beforehand or something should be done?

Oct 18 2018, 7:32 AM · Contributor Reviews (base)

Oct 15 2018

alvisen_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

It works, but there is only one button and no two finger scrolling, whereas with psm I have 3 buttons (one, two and three finger taps) and two finger scrolling.

Thanks for testing. That your two finger scroll does not work is apparent from the descriptor line identifying only two axis, namely X and Y. For scrolling to work, there should be a Z axis as well. I believe that your touchpad does not only support the mouse reports but also multitouch trackpad reports, but they are not yet considered by iichid. Nevertheless you should be able to use two buttons.

Oct 15 2018, 9:46 AM · Contributor Reviews (base)

Oct 14 2018

marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

...
I haven't spent any significant amount of time looking at the diff yet, but I'll take a stab at answering these.
...

Oct 14 2018, 5:30 PM · Contributor Reviews (base)
alvisen_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

First, good job!

Oct 14 2018, 10:49 AM · Contributor Reviews (base)

Oct 13 2018

markj added a comment to D16698: First draft HID over I2C support (Mouse only).

I was able to use this on a Dell latitude 7480 to get a working trackpad. Thank you!

Oct 13 2018, 10:17 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com updated the summary of D16698: First draft HID over I2C support (Mouse only).
Oct 13 2018, 3:22 PM · Contributor Reviews (base)

Oct 12 2018

marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

I got some open questions that someone actually reviewing this code or just stumbling by might be able to answer:

  1. is PI_TTY the preferred thread priority, or should it be something else?
  2. I read locking(9), mutex(9), bus_setup_intr(9) and a paper on locking mechanisms in FreeBSD and think that I got a fair idea about the basic principles, but I think I still didn't get a grasp on when sleeping is allowed when using an interrupt routine. From what I understand, I almost always need to create a task queue due to the fact that almost all bus implementations call mtx_sleep at some point. Is that correct? Then again I think I saw some modules calling bus operations (that possibly call mtx_sleep) during interrupt handling directly from the associated ithread routine. Are they doing it wrong?
  3. If I use a task queue to handle interrupts and retrieve data from a device and that retrieval method goes to sleep eventually. From my understanding I should release my locks before and reacquire them after the bus operation. What is the preferred method to prevent another thread trying to detach the sleeping module? Possible solutions I figured that might be applicable are flag and condition variable or nested mutex. But what is the right way to do it, or is it even unnecessary because some internal mechanism prevents detaching (device busy msg)?

Thanks for your help.

Oct 12 2018, 8:38 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com updated the summary of D16698: First draft HID over I2C support (Mouse only).
Oct 12 2018, 8:17 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com updated the diff for D16698: First draft HID over I2C support (Mouse only).

I just uploaded a new diff that lacks the changes to usb. iichid for now depends on usb but should be easier to test.

Oct 12 2018, 8:02 PM · Contributor Reviews (base)

Oct 10 2018

b4_gewt.net added a comment to D16698: First draft HID over I2C support (Mouse only).

Besides that, I think you really will have to fix your ig4 problem first (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221777). By the way, the ACPI information you provided there suggests that the HID device is a trackpad. That is not supported yet, since iichid only searches for mouse information in the descriptor.

Oct 10 2018, 10:46 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Hmmm. Does my ACPI table not _know_ there should be an i2c mouse?

Oct 10 2018, 10:09 PM · Contributor Reviews (base)
KOT_MATPOCKuH.Ru accepted D16698: First draft HID over I2C support (Mouse only).

I'm applied this patch to my FreeBSD 12 r338342 box on Dell Latitude 5290 and applied this configuration to rc.conf:
kld_list="/boot/modules/i915kms.ko /boot/modules/iichid.ko /boot/modules/acpi_iichid.ko"
moused_port="/dev/ims0"

Oct 10 2018, 8:34 PM · Contributor Reviews (base)

Oct 8 2018

b4_gewt.net added a comment to D16698: First draft HID over I2C support (Mouse only).

Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
ppc: ppc-1 already exists; skipping it
driver bug: Unable to set devclass (class: ppc devname: (unknown))
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960
Table 'FACP' at 0x78f10960
FACP: Found table at 0x78f10960

Oct 8 2018, 5:32 AM · Contributor Reviews (base)
b4_gewt.net added a comment to D16698: First draft HID over I2C support (Mouse only).

driver bug: Unable to set devclass (class: ppc devname: (unknown))
driver bug: Unable to set devclass (class: ppc devname: (unknown))
ig4iic_acpi0: <Designware I2C Controller> iomem 0xe1122000-0xe1122fff irq 7 on acpi0
ig4iic_acpi0: controller error during attach-1
driver bug: Unable to set devclass (class: ppc devname: (unknown))
ig4iic_acpi1: <Designware I2C Controller> iomem 0xe1124000-0xe1124fff irq 7 on acpi0
ig4iic_acpi1: controller error during attach-1
iicbus0: <Philips I2C bus> on ig4iic_acpi0
iic0: <I2C generic I/O> on iicbus0
iicbus1: <Philips I2C bus> on ig4iic_acpi1
iic1: <I2C generic I/O> on iicbus1
driver bug: Unable to set devclass (class: ppc devname: (unknown))
wlan0: Ethernet address: 6c:29:95:4e:a3:68

Oct 8 2018, 5:29 AM · Contributor Reviews (base)

Oct 6 2018

marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Hello Marc,

Thanks for your quick answer.

My revision is r339210. So I guess I should try 338291.

Regards

Thomas

Oct 6 2018, 2:01 PM · Contributor Reviews (base)
tfagart_brozs.net added a comment to D16698: First draft HID over I2C support (Mouse only).

Hello Marc,

Oct 6 2018, 1:05 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Hi Thomas,

Oct 6 2018, 12:27 PM · Contributor Reviews (base)
tfagart_brozs.net added a comment to D16698: First draft HID over I2C support (Mouse only).

First thanks for your work. I've got a Dell Latitude 5590. Scanning I2C bus now work.
root@pcb-prdtfa-07:~ # i2c -f /dev/iic1 -s
Hardware may not support START/STOP scanning; trying less-reliable read method.
Scanning I2C devices on /dev/iic1: 2c

Oct 6 2018, 10:30 AM · Contributor Reviews (base)

Sep 26 2018

bdrewery closed D15119: Handle overflow of uid or gid in arguments for chown.
Sep 26 2018, 6:41 PM · Contributor Reviews (base)
delphij added inline comments to D15119: Handle overflow of uid or gid in arguments for chown.
Sep 26 2018, 6:33 PM · Contributor Reviews (base)

Sep 22 2018

marc.priggemeyer_gmail.com updated the test plan for D16698: First draft HID over I2C support (Mouse only).
Sep 22 2018, 9:32 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com updated the diff for D16698: First draft HID over I2C support (Mouse only).
  • Tested against base revision 338291.
  • Sampling mode was added to periodically poll for reporrts (see Test Plan for further information)
  • Still make sure to have a running iicbus implementation
  • it was reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221777 that a panic occures when trying to load iichid and acpi_iichid by bootloader kld_list in rc.conf is still the way to go if you tested manually beforehand.
Sep 22 2018, 9:25 PM · Contributor Reviews (base)