Page MenuHomeFreeBSD

Linux EmulationUmbrella
ActivePublic

Recent Activity

Nov 8 2019

emaste updated subscribers of D7977: Linux ARM v2 8/9.

It looks like the copyright header is a leftover from some earlier copy-paste. If this is just your work based on @kib's it should presumably have a standard 2-clause BSD license.

Nov 8 2019, 11:25 PM · Linux Emulation, ARM
emaste closed D7972: Linux ARM v2 3/9.
Nov 8 2019, 2:17 PM · Linux Emulation, ARM

May 7 2019

emaste added a comment to D7970: Linux ARM v2 1/9.

Hello,
This patchset has been created for FreeBSD 11. It has not been tested nor maintened since and I currently don't have time to work on it. I think we can drop it (it can be a base for new contributors).
Thanks

May 7 2019, 1:27 PM · Linux Emulation, ARM
emaste updated the diff for D7973: Linux ARM v2 4/9.

Upload rebased and updated diff - add arm linuxulator syscalls.conf and Makefile, from arm64

May 7 2019, 1:25 PM · Linux Emulation, ARM
soutade_gmail.com added a comment to D7970: Linux ARM v2 1/9.

This patchset has been created for FreeBSD 11. It has not been tested nor maintened since and I currently don't have time to work on it. I think we can drop it (it can be a base for new contributors).

May 7 2019, 7:16 AM · Linux Emulation, ARM

May 6 2019

cneirabustos_gmail.com added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 6 2019, 11:07 PM · Linux Emulation, Contributor Reviews (base)
dchagin added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 6 2019, 9:29 PM · Linux Emulation, Contributor Reviews (base)
dchagin closed D13656: Bug 223722 add sys/class/net data to linsysfs.
May 6 2019, 8:01 PM · Linux Emulation, Contributor Reviews (base)
emaste added a comment to D7973: Linux ARM v2 4/9.

Oops, updated this review with the diff intended for D7972.

May 6 2019, 7:50 PM · Linux Emulation, ARM
emaste updated the diff for D7972: Linux ARM v2 3/9.

Reformat arm linux syscalls.master per current style

May 6 2019, 7:47 PM · Linux Emulation, ARM
emaste commandeered D7972: Linux ARM v2 3/9.
May 6 2019, 7:47 PM · Linux Emulation, ARM
cneirabustos_gmail.com added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 6 2019, 5:39 PM · Linux Emulation, Contributor Reviews (base)
emaste added inline comments to D7973: Linux ARM v2 4/9.
May 6 2019, 5:36 PM · Linux Emulation, ARM
emaste updated the diff for D7973: Linux ARM v2 4/9.

Reformat arm linux syscalls.master per current style

May 6 2019, 5:33 PM · Linux Emulation, ARM
emaste commandeered D7973: Linux ARM v2 4/9.
May 6 2019, 5:32 PM · Linux Emulation, ARM
emaste added a comment to D7973: Linux ARM v2 4/9.
In D7973#164964, @imp wrote:

If this is just generated code, it doesn't need a code review :)

May 6 2019, 5:21 PM · Linux Emulation, ARM
emaste added a comment to D7972: Linux ARM v2 3/9.

Oh I see @brooks already mentioned that.

May 6 2019, 4:54 PM · Linux Emulation, ARM
emaste added a comment to D7972: Linux ARM v2 3/9.

We'll also want to switch this to the new style -- see rS347186 for arm64.

May 6 2019, 4:19 PM · Linux Emulation, ARM
emaste added a comment to D7970: Linux ARM v2 1/9.

This should probably come at the end - add the source first, build infrastructure after.

May 6 2019, 4:15 PM · Linux Emulation, ARM

May 1 2019

cem added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 1 2019, 9:20 PM · Linux Emulation, Contributor Reviews (base)
dchagin added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 1 2019, 8:05 PM · Linux Emulation, Contributor Reviews (base)
brooks added a comment to D7972: Linux ARM v2 3/9.

Since this is a new file, you might want to consider formatting it in the new, more readable style used in sys/kern/syscalls.master.

May 1 2019, 5:45 PM · Linux Emulation, ARM

Apr 30 2019

emaste added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

For future updates (to this review, if any, or other reviews) please include context e.g. git diff -U9999

Apr 30 2019, 8:35 PM · Linux Emulation, Contributor Reviews (base)
kib abandoned D15823: Linuxlator enable ptrace.
Apr 30 2019, 6:48 PM · Linux Emulation
kib commandeered D15823: Linuxlator enable ptrace.
Apr 30 2019, 6:48 PM · Linux Emulation
kib added a comment to D15823: Linuxlator enable ptrace.

I believe that was superseded by D15857, which was committed quite some time ago.

Apr 30 2019, 6:48 PM · Linux Emulation
dchagin added a reviewer for D13656: Bug 223722 add sys/class/net data to linsysfs: dchagin.
Apr 30 2019, 6:32 PM · Linux Emulation, Contributor Reviews (base)
dchagin removed a reviewer for D7970: Linux ARM v2 1/9: dchagin.
Apr 30 2019, 6:28 PM · Linux Emulation, ARM
dchagin removed a reviewer for D7971: Linux ARM v2 2/9: dchagin.
Apr 30 2019, 6:28 PM · Linux Emulation, ARM
dchagin removed a reviewer for D7972: Linux ARM v2 3/9: dchagin.
Apr 30 2019, 6:28 PM · Linux Emulation, ARM
dchagin removed a reviewer for D7977: Linux ARM v2 8/9: dchagin.
Apr 30 2019, 6:27 PM · Linux Emulation, ARM
dchagin removed a reviewer for D7975: Linux ARM v2 6/9: dchagin.
Apr 30 2019, 6:27 PM · Linux Emulation, ARM
dchagin removed a reviewer for D7978: Linux ARM v2 9/9: dchagin.
Apr 30 2019, 6:26 PM · Linux Emulation, ARM
dchagin removed a reviewer for D7974: Linux ARM v2 5/9: dchagin.
Apr 30 2019, 6:26 PM · Linux Emulation, ARM
dchagin removed a reviewer for D7973: Linux ARM v2 4/9: dchagin.
Apr 30 2019, 6:26 PM · Linux Emulation, ARM
dchagin removed a reviewer for D15823: Linuxlator enable ptrace: dchagin.
Apr 30 2019, 6:23 PM · Linux Emulation

Mar 25 2019

cneirabustos_gmail.com added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

Mar 25 2019, 5:15 PM · Linux Emulation, Contributor Reviews (base)
dchagin added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

Mar 25 2019, 2:07 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

updated patch to address style(9) issues.

Mar 25 2019, 1:19 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com updated the diff for D13656: Bug 223722 add sys/class/net data to linsysfs.

Fixed latest style issue.

Mar 25 2019, 1:18 PM · Linux Emulation, Contributor Reviews (base)

Mar 24 2019

dchagin added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

style (9)

Mar 24 2019, 7:29 AM · Linux Emulation, Contributor Reviews (base)

Mar 21 2019

cneirabustos_gmail.com updated the diff for D13656: Bug 223722 add sys/class/net data to linsysfs.

Fixed style.

Mar 21 2019, 3:57 PM · Linux Emulation, Contributor Reviews (base)

Jun 30 2018

dbn abandoned D13870: lang/linux-dotnet-(runtime|sdk): add linux implementation of .NET Core.
Jun 30 2018, 8:19 PM · Linux Emulation
dbn added a comment to D13870: lang/linux-dotnet-(runtime|sdk): add linux implementation of .NET Core.

Committed in r473600

Jun 30 2018, 8:19 PM · Linux Emulation
dbn added inline comments to D13870: lang/linux-dotnet-(runtime|sdk): add linux implementation of .NET Core.
Jun 30 2018, 7:33 AM · Linux Emulation

Jun 18 2018

mat added inline comments to D13870: lang/linux-dotnet-(runtime|sdk): add linux implementation of .NET Core.
Jun 18 2018, 10:42 AM · Linux Emulation

Jun 17 2018

dbn updated the diff for D13870: lang/linux-dotnet-(runtime|sdk): add linux implementation of .NET Core.

Downgrade dotnet from 2.1 to 2.0. Dotnet 2.1 uses Linux's /proc/$PID/maps output for various purposes, however FreeBSD has a but whereby output is truncated at 128KiB. This breaks the parsing of the output.

Jun 17 2018, 7:06 PM · Linux Emulation

Jun 16 2018

yanko.yankulov_gmail.com added a comment to D15823: Linuxlator enable ptrace.

Just one more question. I can't figure out why we can't reparent the new proc in do_fork instead of waiting for its thread to do it? Any hint will be appreciated.

I am not sure about your question. Can you point to the exact piece of code which you want to move into do_fork ? If you mean proc_reparent() call from fork_return(), I put it there to have all code dealing with the attaching new child to the debugger, in single place. ptracestop() must be called from the stopping thread context, and proc_reparent() as part of the attachment code is naturally located nearby. But I may be mis-interpreting your question, and also I do not see why you are asking.

Yes, that the question. I was trying to figure out why we need the sleep in the fork path at all. Because if we can get rid of the sleep, there is no need to change anything else. So my reasoning was like this - it is either required by the ptrace interface/promises i.e. parent process will not continue execution before the child is attached, or it is part of the implementation of the interface.
I assumed it is not a ptrace requirement because there is no guarantees for the parent/child execution in non-ptraced mode, and went on to see why it might be needed. One thing in the current code is that we can't allow the parent process to exit before the child was reparented as we will not attach to the child.
So my question is if we reparent the child in do_fork wouldn't it be possible and desirable to drop the wait altogether?

Jun 16 2018, 7:17 PM · Linux Emulation
yanko.yankulov_gmail.com added a comment to D15823: Linuxlator enable ptrace.

Just one more question. I can't figure out why we can't reparent the new proc in do_fork instead of waiting for its thread to do it? Any hint will be appreciated.

I am not sure about your question. Can you point to the exact piece of code which you want to move into do_fork ? If you mean proc_reparent() call from fork_return(), I put it there to have all code dealing with the attaching new child to the debugger, in single place. ptracestop() must be called from the stopping thread context, and proc_reparent() as part of the attachment code is naturally located nearby. But I may be mis-interpreting your question, and also I do not see why you are asking.

Jun 16 2018, 3:22 PM · Linux Emulation
kib added a comment to D15823: Linuxlator enable ptrace.

I checked the rest of the RFSTOPPED use points and applying the change seems trivial. So if the general idea is acceptable I can apply the changes to all the places and upload a new patch.

Right now I think that this is working approach.

Jun 16 2018, 2:57 PM · Linux Emulation