Nov 8 2019
It looks like the copyright header is a leftover from some earlier copy-paste. If this is just your work based on @kib's it should presumably have a standard 2-clause BSD license.
May 7 2019
Upload rebased and updated diff - add arm linuxulator syscalls.conf and Makefile, from arm64
This patchset has been created for FreeBSD 11. It has not been tested nor maintened since and I currently don't have time to work on it. I think we can drop it (it can be a base for new contributors).
May 6 2019
Oops, updated this review with the diff intended for D7972.
Reformat arm linux syscalls.master per current style
Reformat arm linux syscalls.master per current style
Oh I see @brooks already mentioned that.
We'll also want to switch this to the new style -- see rS347186 for arm64.
This should probably come at the end - add the source first, build infrastructure after.
May 1 2019
Since this is a new file, you might want to consider formatting it in the new, more readable style used in sys/kern/syscalls.master.
Apr 30 2019
For future updates (to this review, if any, or other reviews) please include context e.g. git diff -U9999
I believe that was superseded by D15857, which was committed quite some time ago.
Mar 25 2019
ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?
updated patch to address style(9) issues.
Fixed latest style issue.
Mar 24 2019
style (9)
Mar 21 2019
Fixed style.
Jun 30 2018
Committed in r473600
Jun 18 2018
Jun 17 2018
Downgrade dotnet from 2.1 to 2.0. Dotnet 2.1 uses Linux's /proc/$PID/maps output for various purposes, however FreeBSD has a but whereby output is truncated at 128KiB. This breaks the parsing of the output.
Jun 16 2018
Just one more question. I can't figure out why we can't reparent the new proc in do_fork instead of waiting for its thread to do it? Any hint will be appreciated.
I am not sure about your question. Can you point to the exact piece of code which you want to move into do_fork ? If you mean proc_reparent() call from fork_return(), I put it there to have all code dealing with the attaching new child to the debugger, in single place. ptracestop() must be called from the stopping thread context, and proc_reparent() as part of the attachment code is naturally located nearby. But I may be mis-interpreting your question, and also I do not see why you are asking.
Right now I think that this is working approach.