Moved struct dev_pm_info power member to bottom of struct device in <linux/device.h>

Various changes to pci_power_name() thanks to @hselasky

• Added bound checking to pci_power_name()
• Made pci_power_names array external

Used memdup_user_nul() instead of memdup_user() to duplicate memory from userspace. Relevant documentation can be found here:

Removed NULL pointer error checking thanks to @markj. General user pointers are safely checked in memdup_user().

Looks good!

Added simple error checking

Assuming there is no special case for n = 0.

Also if uploading an updated version please include full context (e.g. git diff -U999999 or git show -U999999)

So the specific use case is file to file copy? In that case the code should employ kern_copy_file_range (or something lower, to the same extent). That's aside of generic whatever-to-whatever copying added here.

commented on a couple of style(9)-related things that IMO are fine to leave the way they are if @dchagin agrees

thank you, you can test using linux test project, also, please, read style(9) and fix patch

Linking for convenience, a cgit range that inclues the four commits: https://cgit.freebsd.org/src/log/?qt=range&q=7f4e724829e556fc646056669c2af3551b7e8724...67af9aba6b144789734289443a5f90a3ca716dbe

In D30332#691452, @pitwuu_gmail.com wrote:

In D30332#691205, @dchagin wrote:

Im don't understand what do you mean, I mean that musl it's a separate brand, see Elf_Brandinfo and linux_sysvec.c,
and only for musl brand we should change cmp_requeue, for glibc brand cmp_requeue should return EINVAL

Well. No. Musl doesn't have different brands for the elf files, only the path of the interp differs, and in any case we are a Linuxulator, not a glibculator, it's better to just remain agnostic of the userland and let it sort itself out like is expected of the kernel.

If there's a quirk for some ancient glibc version then make that a knob somewhere or break it in favour of modern (read from this decade) versions.

In D30332#691205, @dchagin wrote:

Im don't understand what do you mean, I mean that musl it's a separate brand, see Elf_Brandinfo and linux_sysvec.c,
and only for musl brand we should change cmp_requeue, for glibc brand cmp_requeue should return EINVAL

Im don't understand what do you mean, I mean that musl it's a separate brand, see Elf_Brandinfo and linux_sysvec.c,
and only for musl brand we should change cmp_requeue, for glibc brand cmp_requeue should return EINVAL

FWIW, splice: https://reviews.freebsd.org/D30597

we have so many such unfinished things

In D30378#684094, @trasz wrote:

FWIW, splice(2) can be a wrapper around copy_file_range(2). We should also have a fallback from sendfile(2) to splice(2), for when it fails with ENOTSOCK. This is one of the things that break Mono

Why do we need it? All the BSD's seem to exist without splice() just fine?

The most pressing issue is the incomplete pthread support notably with FUTEX_LOCK_PI and FUTEX_UNLOCK_PI and friends.

https://wiki.freebsd.org/Linuxulator#Roadmap, pi is not the key, we have so many important holes

It's literally the second item on that list, for example pulseaudio hard crashes because it's not there. I have started but it's pretty hard, I wonder if anyone can help?

FWIW, splice(2) can be a wrapper around copy_file_range(2). We should also have a fallback from sendfile(2) to splice(2), for when it fails with ENOTSOCK. This is one of the things that break Mono.