In D58228#1349195, @bz wrote:

What's the KBI impact of this? Does it need a __FreeBSD_version bump then? Would it make sense to add it to the end?

Just bumping if anyone has time

Just bumping

What's the KBI impact of this? Does it need a __FreeBSD_version bump then? Would it make sense to add it to the end?

@bz Let me know if you've got any time to look over these changes. Thank you!

That looks fine to me, at least.

For reference, moved to D56251

I did not originally include all the syscall.master files' changes, they've now been included, @Nimish Jain also helped point out that I could simplify the function quite a bit.

create a pull request on github...

This is created from diff file. I just created another one followed the instructions with arc command

Remove additional unexpected empty line change

This is unrelated to LinuxKPI. Remove the reviewer.

looks OK, but tagging for srcmgr review since some of it looks weird too :)

code looks OK, though my arm assembler is rusty. tagged as srcmgr for review

srcmgr review, likely OK, but not actually accepted.

Wonder what the status of this is... Tagging for srcmgr review, even though it didn't make it to accepted.

tagging for srcmgr review. These are all likely a sea of conflicts now, but that should be easy to resolve.

Looks like this would be easy to forward port. But the patch series likely needs some work. tagging for srcmgr review.

Due to D41976

In D41859#955406, @kib wrote:

In D41859#955405, @dchagin wrote:

In D41859#955376, @kib wrote:

In D41859#955367, @dchagin wrote:

Btw, the way you proposed will not work, due to nosys marked as ABSENT and in such cases syscall_thread_enter() return ENOSYS.

Are you saying that sometimes we do not send SIGSYS for FreeBSD native processes?

yes, OBSOL syscalls, https://people.freebsd.org/~dchagin/nosys.c

And ABSENT as well?

In D41859#955405, @dchagin wrote:

In D41859#955376, @kib wrote:

In D41859#955367, @dchagin wrote:

Btw, the way you proposed will not work, due to nosys marked as ABSENT and in such cases syscall_thread_enter() return ENOSYS.

Are you saying that sometimes we do not send SIGSYS for FreeBSD native processes?

yes, OBSOL syscalls, https://people.freebsd.org/~dchagin/nosys.c

And ABSENT as well?